Awesome IPLD endeavour #74
Conversation
| @@ -2,7 +2,7 @@ | |||
| "name": "ipfs-unixfs-engine", | |||
| "version": "0.11.4", | |||
| "description": "JavaScript implementation of the unixfs Engine used by IPFS", | |||
| "main": "lib/index.js", | |||
| "main": "src/index.js", | |||
There was a problem hiding this comment.
TODO: remove before merge
| @@ -3,14 +3,14 @@ | |||
| const UnixFS = require('ipfs-unixfs') | |||
| const assert = require('assert') | |||
| const pull = require('pull-stream') | |||
| const pushable = require('pull-pushable') | |||
| const write = require('pull-write') | |||
| const pullPushable = require('pull-pushable') | |||
There was a problem hiding this comment.
it helps to know that 'it is a pull stream thing'
daviddias
force-pushed
the
awesome-ipld
branch
10 times, most recently
from
290ca05
to
f4082d5
Compare
|
I've migrated the importer to the Async interfaces and had to go through a major overhaul of the unixfs-engine needs an overhaul cleanup, refactor and simplification, it takes a bit to sync in what is going on inside the code, although the high level algorithm is quite simple. flush-tree.js has improved a lot with this PR. I'm just missing 4 last tests for the importer, namely the ones with directories, traverse is getting called twice for the same dir, increasing the level of nestness, still trying to understand why. Left some logs to help with the debugging. |
|
thank you @diasdavid! lets wait for the full refactoring until we add the hamt though, as that will add additional constraints on the interfaces |
daviddias
force-pushed
the
awesome-ipld
branch
from
f4082d5
to
ad50179
Compare
dignifiedquire
force-pushed
the
awesome-ipld
branch
from
410510d
to
452d545
Compare
|
@diasdavid fixed and rebase |
daviddias
force-pushed
the
awesome-ipld
branch
2 times, most recently
from
b064c80
to
1de430b
Compare
daviddias
force-pushed
the
awesome-ipld
branch
from
1de430b
to
89c3602
Compare
No description provided.