This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
Awesome IPLD endeavour #532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
36 tasks
dignifiedquire
suggested changes
Oct 24, 2016
| if (typeof hash === 'string') { | ||
| return multihash.fromB58String(hash) | ||
| function cleanCid (cid) { | ||
| if (cid.constructor.name === 'CID') { |
There was a problem hiding this comment.
please use require('cids').isCID instead
daviddias
force-pushed
the
awesome-ipld
branch
from
7eb5dcc
to
1ab7c6f
Compare
|
PR Table from: ipld/js-ipld#60 (comment)
|
daviddias
force-pushed
the
awesome-ipld
branch
from
1ab7c6f
to
e28b028
Compare
daviddias
force-pushed
the
awesome-ipld
branch
from
f3ffa9c
to
301dbcf
Compare
|
Can I get some CR ? :) |
daviddias
force-pushed
the
awesome-ipld
branch
from
301dbcf
to
1b0b22d
Compare
|
Also added as a bonus, a refreshed readme :) |
|
@diasdavid why the red CI? |
|
@dignifiedquire it is that 'tmpdir' thing, I was grepping through to find where it was coming from, but with no luck, any idea? |
dignifiedquire
suggested changes
Oct 31, 2016
| @@ -22,7 +22,7 @@ function addBlock (buf) { | |||
| throw err | |||
| } | |||
|
|
|||
| console.log(bs58.encode(block.key).toString()) | |||
| console.log(bs58.encode(block.key()).toString()) | |||
There was a problem hiding this comment.
Why doesn't this throw, shouldn't block.key() be async?
There was a problem hiding this comment.
Not the released version apparently https://github.com/ipfs/js-ipfs-block
| const link = new DAGLink(argv.name, size, multihash) | ||
|
|
||
| ipfs.object.patch.addLink(argv.root, link, {enc: 'base58'}) | ||
| .then((node) => { |
There was a problem hiding this comment.
let's not use promises mixed with callback
| @@ -10,7 +10,7 @@ const createTempNode = require('../utils/temp-node') | |||
| const repoPath = require('./index').repoPath | |||
| const ipfs = require('../utils/ipfs-exec')(repoPath) | |||
|
|
|||
| describe('bitswap', () => { | |||
| describe.skip('bitswap', () => { | |||
There was a problem hiding this comment.
Just for a little bit :)
daviddias
force-pushed
the
awesome-ipld
branch
from
e9a5388
to
6f6b1e7
Compare
daviddias
force-pushed
the
awesome-ipld
branch
3 times, most recently
from
ce53361
to
ffdf640
Compare
daviddias
force-pushed
the
awesome-ipld
branch
from
ffdf640
to
689cfba
Compare
MicrowaveDev
pushed a commit
to galtproject/js-ipfs
that referenced
this pull request
May 22, 2020
chore: upgrade dag-pb to the new, new api
This was referenced Apr 7, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes js-ipfs understand how to use IPLD.
As a compromise, had to turn off bitswap as its migration to IPLD is not trivial. We have a focused milestone for it (Bitswap complete).
The last thing to add to this PR is the new
dagAPI.