Feature complete #4
Conversation
daviddias
added
status/in-progress
daviddias
force-pushed
the
feat/complete
branch
from
fc414a7
to
fb964fd
Compare
|
@dignifiedquire @victorbjelkholm could you review? Thank you :) |
| @@ -2,53 +2,92 @@ | |||
| 'use strict' | |||
|
|
|||
| const expect = require('chai').expect | |||
| const mh = require('multihashes') | |||
| const multihash = require('multihashes') | |||
| const multihashing = require('multihashing') | |||
There was a problem hiding this comment.
Could you please move this to multihashing-async, we don't want slow tests :)
There was a problem hiding this comment.
Definitely something happening next week, however, it would be impossible for me to focus on the IPLD work at hand, if adding to the npm link mad mountain that I had to do, I also had to maintain branches of branches npm linking all over the place :)
There was a problem hiding this comment.
Fair point, starting Monday I will fully focus on getting that merged so we can upgrade these branches and ship ALL THE THINGS.
| 'dag-pb': new Buffer('70', 'hex'), | ||
| 'dag-cbor': new Buffer('71', 'hex'), | ||
| 'eth-block': new Buffer('90', 'hex'), | ||
| 'eth-tx': new Buffer('91', 'hex') | ||
| } |
There was a problem hiding this comment.
Would be nice if we could just pull this directly off of js-multicodec
There was a problem hiding this comment.
💡 Or even a multicodec-table module that gets published directly from the spec repo, this way, all the other multi* can require it and use always the latest.
There was a problem hiding this comment.
do you plan on doing this?
There was a problem hiding this comment.
Once we have multiformats/multicodec#16 finished, otherwise, instead of having codes floating in two places, we would have it floating in three
There was a problem hiding this comment.
Added a note here: multiformats/multicodec#20
| @@ -2,7 +2,7 @@ | |||
| "name": "cids", | |||
| "version": "0.1.1", | |||
| "description": "cid implementation", | |||
| "main": "lib/index.js", | |||
| "main": "src/index.js", | |||
There was a problem hiding this comment.
TODO: remove before merge
| 'dag-pb': new Buffer('70', 'hex'), | ||
| 'dag-cbor': new Buffer('71', 'hex'), | ||
| 'eth-block': new Buffer('90', 'hex'), | ||
| 'eth-tx': new Buffer('91', 'hex') | ||
| } |
There was a problem hiding this comment.
do you plan on doing this?
| this.codec = codec | ||
| this.version = version | ||
| this.multihash = multihash | ||
| } |
There was a problem hiding this comment.
Please throw some kind of error on the non working cases. This is a new format and could easily lead to implicit errors if we fail silently
| } else if (typeof version === 'number') { | ||
| // | ||
| // TODO validate all of these | ||
| // |
There was a problem hiding this comment.
lets add at least some basic validations
|
Thank you for the CR @dignifiedquire, applied, now validation happens and it will throw if something is incorrect. |
update multibase and multicodec add tests add documentation
daviddias
force-pushed
the
feat/complete
branch
from
d9bd1e2
to
211970b
Compare
Support for both v0 and v1 CID.
Ready for review