Skip to content
This repository has been archived by the owner on Aug 11, 2021. It is now read-only.

Awesome IPLD endeavour #1

Merged
merged 12 commits into from
Oct 26, 2016
Merged

Awesome IPLD endeavour #1

merged 12 commits into from
Oct 26, 2016

Conversation

daviddias
Copy link
Member

No description provided.

@daviddias daviddias mentioned this pull request Oct 3, 2016
36 tasks
@@ -1,8 +1,8 @@
{
"name": "ipfs-merkle-dag",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't forget to deprecate the latest versions of these modules on npm with a message that they were renamed

"name": "ipld-dag-pb",
"version": "0.0.1",
"description": "JavaScript Implementation of the MerkleDAG Node in Protobuf.",
"main": "src/index.js",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: change before merge


/*
* tree: returns a flattened array with paths: values of the project. options
* are option (i.e. nestness)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

options are option

this doesn't sound right

return paths
}

// TODO recheck this API
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's the plan here?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants