Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add chevron arrows, SVG optimization, link color #41

Merged
merged 5 commits into from
May 12, 2020

Conversation

jessicaschilling
Copy link
Contributor

@jessicaschilling jessicaschilling commented Apr 30, 2020

NOTE! Please don't merge until we confirm chevrons look good in situ in file import UI.

Proposing as minor release:

  • Adds chevron-style arrow to be used in file import progress UI pattern: stroke_small_arrow.svg and glyph_small_arrow.svg
  • Optimizes all icons for file size
  • Updates gateway link to icon guide doc in readme
  • Adds link color, confirmed WCAG AA compliant on white background

Ref ipfs/ipfs-webui#1206 for icons
Ref ipfs/dir-index-html#29 (comment) for link color

@rafaelramalho19
Copy link

LGTM 😄

In the future, I'll try to change the way we include the fonts in the docs since it involves duplicating the number of changes per PR 🤔

@jessicaschilling
Copy link
Contributor Author

Thanks - holding off on merging this until we know how the chevrons look in progress UI.

@jessicaschilling jessicaschilling changed the title Add chevron arrows, SVG optimization Add chevron arrows, SVG optimization, link color May 5, 2020
@jessicaschilling jessicaschilling merged commit 8390d72 into master May 12, 2020
@jessicaschilling jessicaschilling deleted the addarrows-svgcleanup branch May 12, 2020 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants