Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display progress status while importing files #1206

Closed
andrasfuchs opened this issue Aug 18, 2019 · 12 comments · Fixed by #1495
Closed

Display progress status while importing files #1206

andrasfuchs opened this issue Aug 18, 2019 · 12 comments · Fixed by #1495
Assignees
@jessicaschilling @rafaelramalho19
Labels
effort/days Estimated to take multiple days, but less than a week exp/intermediate Prior experience is likely helpful help wanted Seeking public contribution on this issue kind/bug A bug in existing code (including security flaws) P2 Medium: Good to have, but can wait until someone steps up status/ready Ready to be worked topic/design-front-end Front-end implementation of UX/UI work topic/design-ux UX strategy, research, not solely visual design

Comments

@andrasfuchs
Copy link

I use ipfs-desktop 0.8.0.0 (and go-ipfs 0.4.21) on Windows 10.
When I add a file (or multiple files) by drag-and-drop in the files section of the desktop app, there is no indication about the progress, although it can take a while on my computer if the size of the file is big.

It would be great to have a progress dialog with the details of the process (bytes transferred, percentage, speed, etc.), just like when you copy files using a file manager.
@hacdias
Copy link
Member

hacdias commented Aug 19, 2019

@andrasfuchs hmm... The 'add' button isn't showing the progress? I thought it was. Perhaps there's a bug or we should find a better way to show the progress.

@andrasfuchs
Copy link
Author

I tried both drag-and-dropping the file from Windows Explorer and using the "+Add" button on the Files page, there was no progress bar displayed.

@hacdias hacdias transferred this issue from ipfs/ipfs-desktop Sep 27, 2019
@RubenKelevra
Copy link

I can confirm this for Chrome on Linux as well. I've added a folder with 5k files, just for testing. There's a popup which states how many files there are and if I really want to add them...

After that, there's no information in the UI, you can click freely around.

For the user there's zero feedback that something is in progress.

@jessicaschilling
Copy link
Contributor

Issue ipfs/ipfs-desktop#750 (Inform user about potential delays before added content is reachable at public gateway) is functionally a different request, but tugs on similar strings mental-model-wise. Tying these issues together via this comment, so we can use whichever one is solved first to inform how we present information on the other one.

@jessicaschilling jessicaschilling mentioned this issue Apr 8, 2020
Open
@jessicaschilling jessicaschilling added exp/intermediate Prior experience is likely helpful effort/days Estimated to take multiple days, but less than a week help wanted Seeking public contribution on this issue kind/bug A bug in existing code (including security flaws) P2 Medium: Good to have, but can wait until someone steps up status/ready Ready to be worked topic/design-front-end Front-end implementation of UX/UI work topic/design-ux UX strategy, research, not solely visual design labels Apr 8, 2020
@jessicaschilling jessicaschilling mentioned this issue Apr 8, 2020
Closed
@jessicaschilling jessicaschilling changed the title Feature request: Display a progress dialog while adding files Display progress status while adding files (WebUI) Apr 8, 2020
@jessicaschilling
Copy link
Contributor

Note: This is a duplicate, functionally, of ipfs/ipfs-desktop#1217 for Desktop. Work on these should happen in tandem.

@jessicaschilling
Copy link
Contributor

ETA: Let's reuse whatever pattern we arrive at for download progress status, too. See ipfs/ipfs-desktop#1419 (comment) .

@jessicaschilling jessicaschilling mentioned this issue Apr 28, 2020
Open
@jessicaschilling jessicaschilling changed the title Display progress status while adding files (WebUI) Display progress status while adding or downloading files Apr 29, 2020
@jessicaschilling
Copy link
Contributor

First pass at non-branded wireframes for adding or downloading files:
https://www.figma.com/file/BQjzJcaKuNrNgeDnoZ664D/Web-UI-upload-download-progress?node-id=0%3A1

@lidel, @rafaelramalho19, @hacdias -- would appreciate feedback when you get the chance!

@rafaelramalho19
Copy link
Contributor

LGTM Jessica! If it's okay I'll start working on this 🎉

@lidel
Copy link
Member

lidel commented Apr 30, 2020 •
edited
Loading

LGTM. @rafaelramalho19 check my comments in figma about unifying language and having the same UI for importing files and directories from local machine and from IPFS paths.

This was referenced Apr 30, 2020
Closed
Merged
@jessicaschilling
Copy link
Contributor

Added the chevron expand/collapse arrow to ipfs-css under ipfs-shipyard/ipfs-css#41 ... @rafaelramalho19, once we're assured we like the chevrons in situ, I'll merge and release 😊

@jessicaschilling jessicaschilling changed the title Display progress status while adding or downloading files Display progress status while importing files Apr 30, 2020
@jessicaschilling
Copy link
Contributor

NB: #1481 PRs for replacing "add" language with "import" language throughout Web UI.

@rafaelramalho19
Copy link
Contributor

Due to limitations with the current usage of HTTP for file imports in WebUI, we're unable to show progress properly.
So for the time being, we'll switch the initial approach to infinite loading indicators and we'll switch back in the future.

@rafaelramalho19 rafaelramalho19 mentioned this issue May 18, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jessicaschilling jessicaschilling

@rafaelramalho19 rafaelramalho19

Labels
effort/days Estimated to take multiple days, but less than a week exp/intermediate Prior experience is likely helpful help wanted Seeking public contribution on this issue kind/bug A bug in existing code (including security flaws) P2 Medium: Good to have, but can wait until someone steps up status/ready Ready to be worked topic/design-front-end Front-end implementation of UX/UI work topic/design-ux UX strategy, research, not solely visual design
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feat/files progress feedback ipfs/ipfs-webui
6 participants
@lidel @RubenKelevra @andrasfuchs @jessicaschilling @hacdias @rafaelramalho19