standard #23
Merged
standard #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Shoot; pulled in something from another branch. Lemme revert it out of this PR. |
This reverts commit b37267b.
| @@ -4,7 +4,7 @@ | |||
| "description": "Quick and simple deploy tool to host Native Web Applications and Static Web Pages in IPFS", | |||
| "bin": "bin.js", | |||
| "scripts": { | |||
| "test": "echo \"Error: no test specified\" && exit 1" | |||
| "test": "standard" | |||
There was a problem hiding this comment.
following the style of other js projects, we do "lint": "standard" and reserve the test keyword for tests.
for pre-commit hook, we use pre-commit and add to the package.json
pre-commit: [
"lint",
"test", // <- if any
"coverage" // <- if any
]There was a problem hiding this comment.
Done! I like keeping "lint" and "test" more explicitly divided.
Is there a style guide somewhere for JS IPFS projects?
|
Thank you @noffle :D @RichardLitt is working on the js guidelines ipfs/community#92 |
|
@diasdavid we're all working on the js guidelines. :) I'm just putting it into a readme. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ipscendis already using StandardJS -- this just adds it tonpm test. It'd also work as a pre-commit hook though.