Added js guidelines #92
Conversation
| - Build system: Use `npm run` for small projects; for larger ones, use `gulp`. | ||
| - Testing node: `mocha` | ||
| - Testing browser: `karma` + `mocha` | ||
| - Browser building: `webpack` or `browserify` (this fight is still ongoing ;) |
There was a problem hiding this comment.
let's not call it a fight, rather point it to issues where discussion is happening and invite folks to collaborate. We really shouldn't even have to lock on either, WebPack is mainly used by front end devs while browserify has a lot of users that are Node.js developers hacking on the browser.
There was a problem hiding this comment.
I still suggest we put webpack here as the main choice as we are using that atm in all new projects. These are only guidelines no hard rules anyway.
There was a problem hiding this comment.
So, confession: I'm a browserify person. I'm not going to suggest one over the other. @diasdavid is right about node devs. I'll remove the fight comment.
This should close #59
RichardLitt
force-pushed
the
feature/js-guide
branch
from
6f414fc
to
d7ce529
Compare
|
So, I changed it up a bit, and made two sections: one for contributors, and one for maintainers. This should make the entire thing easier. I think the three contributor suggestions are clear and make sense. Sound good? cc @noffle @diasdavid @dignifiedquire |
|
Two more things
|
RichardLitt
force-pushed
the
feature/js-guide
branch
from
a78074d
to
d7983cc
Compare
|
Added. All good? |
|
LGTM |
| - Browser building: [webpack](https://webpack.github.io/) or [browserify](http://browserify.org/). | ||
| - Linting: Use [standard](//github.com/feross/standard). If you have to configure styles at the repo level because you or we are using Babel and ES6, use [eslint](https://github.com/eslint/eslint), [eslint-config-standard](https://github.com/feross/eslint-config-standard), and [babel-eslint](https://github.com/babel/babel-eslint) as needed. (If you're not sure, use standard). | ||
| - Use [greenkeeper](http://greenkeeper.io/) to keep your deps up to date. | ||
| - Use [precommit](https://www.npmjs.com/package/pre-commit) and [ghooks](https://www.npmjs.com/package/ghooks) to run tests while developing. |
There was a problem hiding this comment.
Do we use ghooks for any project?
There was a problem hiding this comment.
It's just a recommendation. You don't have to use it.
This should close #59