Skip to content
This repository has been archived by the owner on Feb 1, 2023. It is now read-only.

Deduplicate provider logic #52

Closed
Stebalien opened this issue Dec 29, 2018 · 0 comments · Fixed by #64
Closed

Deduplicate provider logic #52

Stebalien opened this issue Dec 29, 2018 · 0 comments · Fixed by #64
Assignees
@hannahhoward

Comments

@Stebalien
Copy link
Member

We currently find providers in both the providerQueueManager and in the sessions. We should:

  1. Improve the session's version of this to match what we have in the providerQueueManager. That is, we should be deduplicating and rate limiting requests.
  2. Get rid of the duplicate logic. We probably don't even need the reboadcastWorker. Sessions should handle this for us.
@hannahhoward hannahhoward self-assigned this Jan 10, 2019
@hannahhoward hannahhoward mentioned this issue Jan 10, 2019
Merged
hannahhoward added a commit that referenced this issue Jan 23, 2019
@hannahhoward
feat(ProviderQueryManager): integrate in sessions
464ce48 
Integrate the ProviderQueryManager into the SessionPeerManager and bitswap in general

re #52, re #49
@hannahhoward hannahhoward mentioned this issue Jan 23, 2019
Merged
hannahhoward added a commit that referenced this issue Jan 23, 2019
@hannahhoward
feat(ProviderQueryManager): integrate in sessions
11eb48a 
Integrate the ProviderQueryManager into the SessionPeerManager and bitswap in general

re #52, re #49
hannahhoward added a commit that referenced this issue Jan 26, 2019
@hannahhoward
feat(ProviderQueryManager): integrate in sessions
8b04f7f 
Integrate the ProviderQueryManager into the SessionPeerManager and bitswap in general

re #52, re #49
hannahhoward added a commit that referenced this issue Jan 26, 2019
@hannahhoward
refactor(GetBlocks): Merge session/non-session
954f481 
Make Bitswap GetBlocks just create a temporary session and use that code

fix #52 fix #49
@hannahhoward hannahhoward mentioned this issue Jan 26, 2019
Merged
@ghost ghost added the status/in-progress In progress label Jan 26, 2019
hannahhoward added a commit that referenced this issue Jan 30, 2019
@hannahhoward
refactor(GetBlocks): Merge session/non-session
61ec06d 
Make Bitswap GetBlocks just create a temporary session and use that code

fix #52 fix #49
hannahhoward added a commit that referenced this issue Jan 30, 2019
@hannahhoward
feat(ProviderQueryManager): integrate in sessions
843391e 
Integrate the ProviderQueryManager into the SessionPeerManager and bitswap in general

re #52, re #49
hannahhoward added a commit that referenced this issue Jan 30, 2019
@hannahhoward
refactor(GetBlocks): Merge session/non-session
5c395fd 
Make Bitswap GetBlocks just create a temporary session and use that code

fix #52 fix #49
hannahhoward added a commit that referenced this issue Feb 5, 2019
@hannahhoward
refactor(GetBlocks): Merge session/non-session
7643ad2 
Make Bitswap GetBlocks just create a temporary session and use that code

fix #52 fix #49
@ghost ghost removed the status/in-progress In progress label Feb 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@hannahhoward hannahhoward

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(GetBlocks): Merge session/non-session ipfs/go-bitswap
2 participants
@Stebalien @hannahhoward