This repository has been archived by the owner on Feb 1, 2023. It is now read-only.
refactor(GetBlocks): Merge session/non-session #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
hannahhoward
changed the title
hannahhoward
force-pushed
the
feat/merge-get-blocks
branch
from
954f481
to
61ec06d
Compare
hannahhoward
force-pushed
the
feat/enhance-session-provider
branch
from
c5678f1
to
56d9e3f
Compare
hannahhoward
force-pushed
the
feat/merge-get-blocks
branch
from
61ec06d
to
5c395fd
Compare
michaelavila
approved these changes
Feb 4, 2019
There was a problem hiding this comment.
I realize there's the other PR (#60) to get through, but barring anything there this looks straightforward and 👍
hannahhoward
force-pushed
the
feat/merge-get-blocks
branch
from
5c395fd
to
7643ad2
Compare
hannahhoward
changed the base branch from
feat/enhance-session-provider
to
master
Jorropo
pushed a commit
to Jorropo/go-libipfs
that referenced
this pull request
Jan 26, 2023
refactor(GetBlocks): Merge session/non-session This commit was moved from ipfs/go-bitswap@5b807cb
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals
Simplify Bitswap!
Implementation
For Discussion
This is PR'd against enhance-session-provider because it's neccesary to make this all work.
The order is:
feat/stabilize-tests ->
feat/enhance-session-provider ->
feat->merge-get-blocks
fix #52 fix #49