This repository has been archived by the owner on Jun 19, 2023. It is now read-only.
correctly convert the datastore not found errors #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stebalien
force-pushed
the
fix/not-found-err
branch
from
52be064
to
0d5887b
Compare
Stebalien
force-pushed
the
fix/not-found-err
branch
from
4806735
to
5d1a33c
Compare
|
magik6k
approved these changes
Aug 7, 2018
Stebalien
commented
Aug 7, 2018
| case cacheHave: | ||
| return bool(h), -1, true | ||
| case cacheSize: | ||
| return true, int(h), true | ||
| } | ||
| } | ||
| return false, -1, false | ||
| } | ||
|
|
||
| func (b *arccache) Has(k *cid.Cid) (bool, error) { |
There was a problem hiding this comment.
I rushed this change through as I ended up leaving a bunch of packages semi-broken (due to ipfs/go-datastore#92).
Before, arccache.Has would always call GetSize on the underlying datastore. Now, it calls Has unless someone as already called GetSize or Get (to avoid the overhead of actually getting the value). Will this change interfere with your bitswap changes?
There was a problem hiding this comment.
@Stebalien
No, this will not interfere with my bitswap changes. I tested both your recent changes and my bitswap changes together. They both look good.
Thank you for your help and the quick turnaround.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.