gx: update blockstore and path #5348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
Blocked on ipfs/go-ipfs-blockstore#10. |
|
|
|
I'd do this here, shouldn't take long to merge. |
License: MIT Signed-off-by: Steven Allen <steven@stebalien.com>
see: ipfs/go-path#1 License: MIT Signed-off-by: Steven Allen <steven@stebalien.com>
License: MIT Signed-off-by: Steven Allen <steven@stebalien.com>
Stebalien
force-pushed
the
feat/update-blockstore-path
branch
from
b3bb929
to
eac8072
Compare
Stebalien
added
need/review
|
This is no longer blocked and should be ready for review. |
magik6k
reviewed
Aug 7, 2018
filestore/filestore.go
Outdated
| // try filestore | ||
| } | ||
|
|
||
| return f.fm.GetSize(c) |
There was a problem hiding this comment.
You should be able to move this into the switch
(address CR) License: MIT Signed-off-by: Steven Allen <steven@stebalien.com>
Stebalien
force-pushed
the
feat/update-blockstore-path
branch
from
ba13005
to
fb41422
Compare
whyrusleeping
approved these changes
Aug 7, 2018
magik6k
approved these changes
Aug 8, 2018
Stebalien
added
RFM
and removed
status/in-progress
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and apply fixes for changed interfaces