This repository has been archived by the owner on Jun 26, 2023. It is now read-only.
change the Pinner interface to have async pin listing #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
MichaelMure
force-pushed
the
streamed-pins
branch
from
8a58bcf
to
9da23c3
Compare
MichaelMure
added a commit
to MichaelMure/go-ipfs-provider
that referenced
this pull request
Mar 2, 2023
Original change: ipfs/go-ipfs-pinner#24
MichaelMure
force-pushed
the
streamed-pins
branch
from
02fd0c3
to
7b89c83
Compare
MichaelMure
added a commit
to MichaelMure/go-ipfs-provider
that referenced
this pull request
Mar 3, 2023
Original change: ipfs/go-ipfs-pinner#24
This was referenced Mar 3, 2023
MichaelMure
added a commit
to MichaelMure/go-ipfs-provider
that referenced
this pull request
Mar 3, 2023
Original change: ipfs/go-ipfs-pinner#24
MichaelMure
force-pushed
the
streamed-pins
branch
from
7b89c83
to
e9bb752
Compare
MichaelMure
added a commit
to MichaelMure/go-ipfs-provider
that referenced
this pull request
Mar 3, 2023
Original change: ipfs/go-ipfs-pinner#24
MichaelMure
added a commit
to MichaelMure/go-ipfs-provider
that referenced
this pull request
Mar 3, 2023
Original change: ipfs/go-ipfs-pinner#24
|
Corresponding Kubo PR: ipfs/kubo#9692 |
guseggert
suggested changes
Mar 17, 2023
| @@ -3,6 +3,7 @@ module github.com/ipfs/go-ipfs-pinner | |||
| go 1.19 | |||
|
|
|||
| require ( | |||
| github.com/Jorropo/channel v0.0.0-20230303124104-2821e25e07ff | |||
There was a problem hiding this comment.
If we want to return a union of "val or err" from a chan, then it's perfectly idiomatic to return a struct { Pin coreiface.Pin, Err error}, I'd prefer not to add another module to our rat's nest of dependencies for something that already has an established idiom.
There was a problem hiding this comment.
has an established idiom
I don't belive that true, most code in the std is synchronous or uses methods of interface who secretly manage synchronisation.
There was a problem hiding this comment.
We don't need a dependency for this. Please don't do it
MichaelMure
commented
Apr 18, 2023
| @@ -119,14 +120,14 @@ type Pinner interface { | |||
| Flush(ctx context.Context) error | |||
|
|
|||
| // DirectKeys returns all directly pinned cids | |||
| DirectKeys(ctx context.Context) ([]cid.Cid, error) | |||
| DirectKeys(ctx context.Context) channel.ReadOnly[cid.Cid] | |||
There was a problem hiding this comment.
Suggested change
| DirectKeys(ctx context.Context) channel.ReadOnly[cid.Cid] | |
| type StreamedCid struct { | |
| C cid.Cid | |
| Err error | |
| } | |
| DirectKeys(ctx context.Context) chan StreamedCid |
MichaelMure
added a commit
to MichaelMure/boxo
that referenced
this pull request
May 4, 2023
The rational is that if the pin list get big, a synchronous call to get the complete list can delay handling unnecessarily. For example, when listing indirect pins, you can start walking the DAGs immediately with the first recursive pin instead of waiting for the full list. This matters even more on low power device, of if the pin list is stored remotely. Replace: - ipfs/go-ipfs-pinner#24 - ipfs/go-ipfs-provider#48
Merged
Jorropo
pushed a commit
to MichaelMure/boxo
that referenced
this pull request
Jun 2, 2023
The rational is that if the pin list get big, a synchronous call to get the complete list can delay handling unnecessarily. For example, when listing indirect pins, you can start walking the DAGs immediately with the first recursive pin instead of waiting for the full list. This matters even more on low power device, of if the pin list is stored remotely. Replace: - ipfs/go-ipfs-pinner#24 - ipfs/go-ipfs-provider#48
Jorropo
pushed a commit
to MichaelMure/boxo
that referenced
this pull request
Jun 2, 2023
The rational is that if the pin list get big, a synchronous call to get the complete list can delay handling unnecessarily. For example, when listing indirect pins, you can start walking the DAGs immediately with the first recursive pin instead of waiting for the full list. This matters even more on low power device, of if the pin list is stored remotely. Replace: - ipfs/go-ipfs-pinner#24 - ipfs/go-ipfs-provider#48
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rational is that if the pin list get big, a synchronous call to get the complete list can delay handling unnecessarily. For example, when listing indirect pins, you can start walking the DAGs immediately with the first recursive pin instead of waiting for the full list.
This matters even more on low power device, of if the pin list is stored remotely.
Corresponding Kubo PR: ipfs/kubo#9692