This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
Update to pinner having async pin listing #48
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelMure
force-pushed
the
streamed-pins
branch
2 times, most recently
from
cf378be
to
ff76035
Compare
Original change: ipfs/go-ipfs-pinner#24
MichaelMure
force-pushed
the
streamed-pins
branch
from
ff76035
to
093cba1
Compare
guseggert
added
P2
MichaelMure
added a commit
to MichaelMure/boxo
that referenced
this pull request
May 4, 2023
The rational is that if the pin list get big, a synchronous call to get the complete list can delay handling unnecessarily. For example, when listing indirect pins, you can start walking the DAGs immediately with the first recursive pin instead of waiting for the full list. This matters even more on low power device, of if the pin list is stored remotely. Replace: - ipfs/go-ipfs-pinner#24 - ipfs/go-ipfs-provider#48
Merged
Jorropo
pushed a commit
to MichaelMure/boxo
that referenced
this pull request
Jun 2, 2023
The rational is that if the pin list get big, a synchronous call to get the complete list can delay handling unnecessarily. For example, when listing indirect pins, you can start walking the DAGs immediately with the first recursive pin instead of waiting for the full list. This matters even more on low power device, of if the pin list is stored remotely. Replace: - ipfs/go-ipfs-pinner#24 - ipfs/go-ipfs-provider#48
Jorropo
pushed a commit
to MichaelMure/boxo
that referenced
this pull request
Jun 2, 2023
The rational is that if the pin list get big, a synchronous call to get the complete list can delay handling unnecessarily. For example, when listing indirect pins, you can start walking the DAGs immediately with the first recursive pin instead of waiting for the full list. This matters even more on low power device, of if the pin list is stored remotely. Replace: - ipfs/go-ipfs-pinner#24 - ipfs/go-ipfs-provider#48
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original change: ipfs/go-ipfs-pinner#24