Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wait for the nodes to fully stop #5315

Merged
merged 5 commits into from
Jul 31, 2018
Merged

wait for the nodes to fully stop #5315

merged 5 commits into from
Jul 31, 2018

Conversation

Stebalien
Copy link
Member

@Stebalien Stebalien commented Jul 30, 2018 •
edited
Loading

Ideally, we'd fix this in IPTB but I'm tired of this bug and this is the easy fix.

fixes #5272

Pass: 5/5.

@Stebalien Stebalien requested a review from Kubuxu as a code owner July 30, 2018 18:58
@ghost ghost assigned Stebalien Jul 30, 2018
@ghost ghost added the status/in-progress In progress label Jul 30, 2018
@Stebalien
Copy link
Member Author

Stebalien commented Jul 30, 2018 •
edited
Loading

Let's run this a few times (on jenkins) to make sure it actually works.

@Stebalien
Copy link
Member Author

Could someone test this on osx? Just run the, e.g., circuit tests.

@Stebalien Stebalien added need/review Needs a review and removed status/in-progress In progress labels Jul 30, 2018
@Stebalien Stebalien requested a review from magik6k July 30, 2018 19:04
@ghost ghost added the status/in-progress In progress label Jul 30, 2018
@Stebalien
Copy link
Member Author

Nope. Doesn't fix it. I wonder if this is a resource limit? Testing that now.

@Stebalien
Copy link
Member Author

So, there's a 4096 file descriptor limit. I wonder if that's the issue we're running into.

@Stebalien Stebalien removed the need/review Needs a review label Jul 30, 2018
@Stebalien Stebalien force-pushed the fix/5272 branch 3 times, most recently from 3d143d4 to a2dc97f Compare July 30, 2018 22:23
@Stebalien
Copy link
Member Author

Actually, it looks like an IPTB bug that was fixed was causing for-each to not return an error when it should have. I've updated the dep.

@Stebalien
update iptb
992f857 
License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
@Stebalien
sharness: remove extraneous iptb stop
ca1024a 
License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
@Stebalien
fix private network tests
848a923 
License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
@Stebalien
make faulty tests always pass
e25383e 
see: #4055

License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
@Stebalien
wait for the nodes to fully stop
abad8ca 
Ideally, we'd fix this in IPTB but I'm tired of this bug and this is the easy
fix.

fixes #5272

License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
@Stebalien Stebalien added need/review Needs a review and removed status/in-progress In progress labels Jul 30, 2018
@Stebalien
Copy link
Member Author

This should be ready to go.

@Stebalien Stebalien merged commit 7705240 into master Jul 31, 2018
@Stebalien Stebalien added RFM and removed need/review Needs a review labels Jul 31, 2018
@Stebalien Stebalien deleted the fix/5272 branch July 31, 2018 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magik6k magik6k magik6k approved these changes

@Kubuxu Kubuxu Awaiting requested review from Kubuxu

Assignees

@Stebalien Stebalien

Labels
RFM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Random twonode sharness test fails
2 participants
@Stebalien @magik6k