test: create add-dir benchmark #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
what do you mean they don't align? They are different on your machine than mine? That's to be expected. As far as a github action for running these benchmarks and keeping them posted somewhere.. I think that's an excellent idea and something we should create an issue for (see #170). It would be nice to output those benchmarks in line with the version of helia used when creating them so we can see how things change as we progress. |
* fix: ⚡ 2x improvement Signed-off-by: Nishant Arora <1895906+whizzzkid@users.noreply.github.com> * fix: dag generation with parallelization at each level --------- Signed-off-by: Nishant Arora <1895906+whizzzkid@users.noreply.github.com> Co-authored-by: Russell Dempsey <1173416+SgtPooki@users.noreply.github.com>
|
ping @achingbrain |
whizzzkid
approved these changes
Jul 5, 2023
benchmarks/add-dir/src/helia.ts
Outdated
| const parentDirectoryName = nodePath.dirname(dir).split(nodePath.sep).pop() | ||
| let rootCID = await unixFs.addDirectory({ path: parentDirectoryName }, unixFsAddOptions) | ||
|
|
||
| const children = await Promise.all(dirents.map(async dirent => { |
* fix: use glob source for importing directories - Use `globSource` from ipfs-utils for import - Make all impls return the same CID - Remove the dir size - if the CID is the same that's good enough * chore: fix linting * chore: remove benchmark from workspaces
SgtPooki
commented
Jul 6, 2023
|
@achingbrain are you good with merging this? |
achingbrain
added a commit
that referenced
this pull request
Jan 8, 2024
Updates all deps and fixes linting errors. Renames the `dht` routing to `libp2p` since it's used any and all configured libp2p Content Routers instead of the low-level DHT interface for several releases now. BREAKING CHANGE: uses multiformats v13 and helia v3, renames `dht` routing to `libp2p`
achingbrain
pushed a commit
that referenced
this pull request
Jan 8, 2024
## [@helia/ipns-v4.0.0](https://github.com/ipfs/helia-ipns/compare/@helia/ipns-v3.0.1...@helia/ipns-v4.0.0) (2024-01-08) ### ⚠ BREAKING CHANGES * uses multiformats v13 and helia v3, renames `dht` routing to `libp2p` ### Features * update helia to v3 and multiformats to v13 ([#167](ipfs/helia-ipns#167)) ([a0381b9](ipfs/helia-ipns@a0381b9)) ### Bug Fixes * make @libp2p/interface a dependency ([#159](ipfs/helia-ipns#159)) ([546ecf0](ipfs/helia-ipns@546ecf0)), closes [#158](ipfs/helia-ipns#158)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates a new benchmark that compares adding directories with helia, js-ipfs, and kubo (via ipfsd-ctl)
Related issues