-
Notifications
You must be signed in to change notification settings - Fork 20
Conversation
Here's a proposal for the datastore interface that uses async/await and async iterators. See ipfs/js-ipfs#1670 for context. License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some minor feedback in the tests. Overall the API changes look good and should be straightforward to change for the other datastore's.
this looks amazing !! love the -522 :) On a side note i have been looking into https://github.com/sithmel/iter-tools for iterator utils. It looks pretty good and complete with 1 minor problem the packaging. The author uses TS and does lots of builds es5 cjs, es5 esm, es2018 etc we would use it like ps. Give it a look and tell me what you think. |
I was going to mention that we should probably settle on a tool like that...although I'm loving how easy those tools are to implement. |
License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
Uses async await and async iterators to implement the proposal here ipfs/interface-datastore#25 License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
-522
😁
@vasco-santos it is just minus 199 That said, still great! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much cleaner API, great work on the docs and tests!
@alanshaw please tell me when you need a release. |
Can this be released? |
Tried but got:
|
@alanshaw gave you publish perms |
@daviddias thanks for trying. It needs the latest aegir to build successfully - #26 should do it. |
Also, enable 2FA! 😜 |
Uses async await and async iterators to implement the proposal here ipfs/interface-datastore#25 License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
Here's a proposal for the datastore interface that uses async/await and async iterators.
😄
See ipfs/js-ipfs#1670 for context.
BTW I have no clue about flow types and have probably broken everything...I'll address that later if this PR gets a 👍
cc @ipfs/javascript-team