This repository has been archived by the owner on Mar 23, 2023. It is now read-only.
Refactor fs datastore to us async/await #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zcstarr
force-pushed
the
master
branch
2 times, most recently
from
b872d78
to
43bb286
Compare
dirkmc
suggested changes
Mar 13, 2019
There was a problem hiding this comment.
Nice work @zcstarr 👍
A couple of small things I noticed:
- In FSDatastore:
- line 91: there is a
mkdirp.sync()that could be asynchronous - line 104: the check for the string
does not existcould be replace by using an error code (with the err-code library)
- line 91: there is a
In a few places we catch an error and throw something else. It's probably worth logging the original error message for the error that was caught- nevermind I see that the original error is encapsulated in the thrown error
| }) | ||
| try { | ||
| await fsUnlink(parts.file) | ||
| } catch (err) { |
There was a problem hiding this comment.
Should we ignore the error if it indicates that the file has already been deleted?
| }, cb) | ||
| ], (err) => callback(err)) | ||
| commit: async () /* : Promise<void> */ => { | ||
| await Promise.all((puts.map((put) => this.put(put.key, put.value)))) |
There was a problem hiding this comment.
It may be more efficient to put these in one big Promise.all() instead of two separate ones
| done() | ||
| }) | ||
| ) | ||
| let res = [] |
There was a problem hiding this comment.
AuHau
reviewed
Apr 28, 2019
| "interface-datastore": "~0.6.0", | ||
| "mkdirp": "~0.5.1", | ||
| "pull-stream": "^3.6.9" | ||
| "interface-datastore": "git://github.com/ipfs/interface-datastore.git#refactor/async-iterators", |
There was a problem hiding this comment.
As the refactor/async-iterators PR was merged and the branch deleted this is outdated and breaks things.
8 tasks
|
Any update on this? |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just banged up a quick async/await translation of the js-datastore-fs. I tried to follow ipfs/interface-datastore#25 for guidance. Let me know if this seems right. 3 test fail in this, I believe due to the dependency on datastore core.
I will probably tackle translating that next and then sync the js-ipfs-repo/js-datastore-fs PR's so all test pass.
One thing to note here is that within test, there is a linting error on for await ( x of asyncgenerator){} , which seems spurious, but I might be mistaken here, so if you have insight much appreciated, as well as any comments or corrections. I'm happy to dig in and clean it up!