Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve performance of Linkify PoC #231

Closed
lidel opened this issue Apr 6, 2017 · 1 comment
Closed

Improve performance of Linkify PoC #231

lidel opened this issue Apr 6, 2017 · 1 comment
Labels
help wanted Seeking public contribution on this issue

Comments

@lidel
Copy link
Member

lidel commented Apr 6, 2017 •
edited
Loading 

111447    A124 │ lidel: LinkifyDOM.js hangs on some pages, example: https://github.com/ipfs/webui/pull/229/files
111635         │ And by hang I mean takes very long to work if not hang.
111751   lidel │ A124, yup, it is just a PoC

Test page: https://github.com/ipfs/webui/pull/229/files
@lidel lidel added help wanted Seeking public contribution on this issue UX labels Apr 6, 2017
lidel added a commit that referenced this issue Sep 27, 2017
@lidel
feat: linkify only officially supported custom protocols
44d1811 
- Support `dweb:` address scheme: closes #280
- Disabled support for unsupported schemes, as described in
  #283 (comment)
- Improve performance on complex and dynamic pages: closes #231
@lidel lidel closed this as completed in 93c794d Sep 27, 2017
@lidel
Copy link
Member Author

lidel commented Sep 28, 2017

This should be fixed in v2.0.10. Both XPath selector and MutationObserver got optimized, we also now validate CID when possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Seeking public contribution on this issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lidel