-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Poor Man's Protocol Handlers #283
Conversation
This is an implementation of ridiculous idea from: #164 (comment) I am really sorry.
Awesome :):) Just from a quick glance it might be better to remove |
Good question @lgierth ! |
Right, you get the whole string so you can match whatever you want :) It should only be
This would not be a URL anymore, we'd then have a URL scheme named |
And maybe later also |
For reference ipfs/specs#152 (comment) |
Change suggested in: #283 (comment)
Thanks, I've updated label to: That being said, extension is more liberal at the moment and both Is that okay, or should we explicitly only support Should |
Better only support what's explicitly supported. Otherwise someone will start using it and we eventually 1) break people's stuff when we remove that implicit support, or 2) have to actually continue supporting it.
Yeah can drop fs: |
- Support `dweb:` address scheme: closes #280 - Disabled support for unsupported schemes, as described in #283 (comment) - Improve performance on complex and dynamic pages: closes #231
- Notifications always go to Browser Console - It is possible to disable notification popups: closes #282 - Updated some dependencies
Change suggested in: #283 (comment)
- Support `dweb:` address scheme: closes #280 - Disabled support for unsupported schemes, as described in #283 (comment) - Improve performance on complex and dynamic pages: closes #231
This is an implementation of ridiculous idea from #164 (comment)
I am really sorry, but its the only way to get
dweb://
working across all browsers 🙄As usual, I am not sure how to label checkbox responsible for toggling this feature in Preferences.
Current label looks like this:
Any ideas how to improve it before I merge this PR?