Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to install in Firefox for Android #779

Closed
lidel opened this issue Oct 2, 2019 · 3 comments · Fixed by #812
Closed

Unable to install in Firefox for Android #779

lidel opened this issue Oct 2, 2019 · 3 comments · Fixed by #812
Labels
area/firefox Issues related to Mozilla Firefox status/blocked/upstream-bug Blocked by upstream bugs status/blocked Unable to be worked further until needs are met

Comments

@lidel
Copy link
Member

lidel commented Oct 2, 2019 •
edited
Loading

The fix for #761 is published to AMO as v2.8.6

Unfortunately:

Keeping this issue open until either Firefox for Android 69 is released or https://github.com/mozilla/addons/issues/1101 gets fixed.
@lidel lidel added status/blocked Unable to be worked further until needs are met status/blocked/upstream-bug Blocked by upstream bugs area/firefox Issues related to Mozilla Firefox labels Oct 2, 2019
This was referenced Oct 2, 2019
Closed
Closed
@mohe2015
Copy link

mohe2015 commented Nov 8, 2019

Unfortunately there won't be a Firefox 69 for Android. Instead Mozilla will slowly migrate to the new Firefox Fenix (which currently doesn't support installing addons)

@lidel
Copy link
Member Author

lidel commented Nov 8, 2019 •
edited
Loading

Thank you for pointing that out @mohe2015.
This is unfortunate: we hoped the problem will resolve itself with the new release, but Mozilla shipped 68.x instead. AMO install page is still broken (https://github.com/mozilla/addons/issues/1101).

I am considering reverting #771 in a way that gets executed only in Firefox <69.
Should be fixed in next release, when #812 ships.

lidel added a commit that referenced this issue Nov 8, 2019
@lidel
fix: restore ESR compatibility
f8816e0 
- changes minimal Firefox version to 68
- restores CORS workaround when runtime is Firefox <69.

This makes Companion once again compatible with Firefox ESR
and Fennec-based Firefox for Android.

Closes #784
Closes #779
@lidel lidel mentioned this issue Nov 8, 2019
Merged
lidel added a commit that referenced this issue Nov 11, 2019
@lidel
fix: restore ESR compatibility (#812)
fb5958a 
- changes minimal Firefox version to 68
- restores CORS workaround when runtime is Firefox <69.

This makes Companion once again compatible with Firefox ESR
and Fennec-based Firefox for Android.

Closes #784
Closes #779
@lidel
Copy link
Member Author

lidel commented Nov 12, 2019

v2.9.0.860 (Beta) can be installed on Android (switched min. version to 68).
We will land this to stable channel later this week.

@github-actions github-actions bot mentioned this issue Feb 16, 2023
Closed
@github-actions github-actions bot mentioned this issue Sep 21, 2023
Merged
@lidel lidel mentioned this issue Oct 2, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/firefox Issues related to Mozilla Firefox status/blocked/upstream-bug Blocked by upstream bugs status/blocked Unable to be worked further until needs are met
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: restore ESR compatibility ipfs/ipfs-companion
2 participants
@lidel @mohe2015