Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove XHR CORS workaround for Firefox #771

Merged
merged 1 commit into from
Oct 1, 2019

Conversation

lidel
Copy link
Member

@lidel lidel commented Sep 30, 2019

This change removes workaround introduced in PR #494 and restores redirect of XHRs for IPFS resources in onBeforeRequest, improving overall performance in Firefox.

The original bug (https://bugzilla.mozilla.org/show_bug.cgi?id=1450965) was fixed in Firefox 69, that is why we also bump minimal version.

Closes #436


ed78b96d5d3f71468385f07a1a6c275b
A WebExtension developer in his studio, c. 1628

This change removes woraround introduced in PR #494
and restores redirect in onBeforeRequest.

The original bug was fixed in Firefox 69,
that is why we also bump minimal version.

More info at:
#436 (comment)
@lidel lidel self-assigned this Sep 30, 2019
@lidel lidel merged commit 40b7ab7 into master Oct 1, 2019
@lidel lidel deleted the refactor/remove-cors-workaround-in-firefox branch October 1, 2019 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gateway redirect messes up CORS headers on firefox
1 participant