fix: multi permisison dialogs for the same permission

[alanshaw]

Fixes https://youtu.be/k4TMpAXToJc

Permission requests are asynchronous so it's possible for a user to request the same permission multiple times before a response is received. This PR deals with this case.

You can use the following code to check this PR is working:

Promise.all([ipfs.id(), ipfs.id()]).then(console.log).catch(console.log)

You should see 2 dialogs in master, and 1 dialog in this branch.

[lidel]

Thank you opening this!
Indeed, dialog for every requested API method should appear only once.

Proposed fix works fine for multiple calls of the same API endpoint, but it gets tricky when you add another one:

Promise.all([ipfs.id(), ipfs.files.ls(), ipfs.id(), ipfs.files.ls(), ipfs.files.ls()]).then(console.log).catch(console.log)

Above snippet results in broken dialog for ipfs.files:

This edge case needs to be fixed before we merge this.

[alanshaw]

@lidel is the issue that the second (and other) dialogs appear blank?

[lidel]

Yeah, it looks 'dead' which is bad UX.

[alanshaw]

@lidel fix for the issue is here: #443

[lidel]

@alanshaw perfect, tested together with #443 works as expected 👍 will merge this shortly.

[alanshaw]

🤦‍♂️ sorry, always with the hats