Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: response for multiple acl dialogs get mixed up #443

Merged
merged 1 commit into from
Apr 6, 2018

Conversation

alanshaw
Copy link
Member

@alanshaw alanshaw commented Apr 6, 2018

This is a fix for the issue reported here: #442 (review)

This PR adds checks to the port connect and tab removed listeners to ensure that the tab that is connecting or being closed is the tab that they are in charge of!

To test:

Promise.all([ipfs.id(), ipfs.files.ls(), ipfs.id(), ipfs.files.ls(), ipfs.files.ls()]).then(console.log).catch(console.log)

Expect 5 dialogs to open*, you should be able to respond to each one individually.

* fix for multiple dialogs for the same permission is coming soon in #442

Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested together with #442 works as expected 👍

@lidel lidel merged commit 7ad01fb into ipfs:master Apr 6, 2018
@alanshaw alanshaw deleted the fix/multi-acl-dialog-responses branch April 6, 2018 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants