Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app icon on osx is the normal electron icon #5

Closed
jbenet opened this issue Jun 5, 2015 · 5 comments
Closed

app icon on osx is the normal electron icon #5

jbenet opened this issue Jun 5, 2015 · 5 comments

Comments

@jbenet
Copy link
Member

jbenet commented Jun 5, 2015

would be nice if it was the large ice IPFS logo

@bcomnes
Copy link
Contributor

bcomnes commented Jun 5, 2015

The dock icon requires packaging tricks iirc. https://github.com/moose-team/friends/blob/master/pkg.js + https://github.com/moose-team/friends/blob/master/package.json#L89 are good examples of this

@krl
Copy link
Contributor

krl commented Jun 13, 2015

this could actually have beon solved by moving the logo from dev-deps into regular deps in #9

I cannot test macosx myself at this point

@krl
Copy link
Contributor

krl commented Jun 13, 2015

@bcomnes We are using the very same packaging script now

@jbenet
Copy link
Member Author

jbenet commented Jun 13, 2015

Actually, this looks to be fixed after using the pkg.js script:

maybe we should use a different name than "electron-ipfs" -- maybe "IPFS Node - Alpha" or "IPFS Node" ?

@jbenet
Copy link
Member Author

jbenet commented Jun 13, 2015

#10

@jbenet jbenet closed this as completed Jun 13, 2015
hacdias added a commit that referenced this issue Dec 1, 2017
# This is the 1st commit message:

start redesign

Too many updates to explain in a commit. See PR :O

add size and objects number

fix addresses and remove agent version

persist file history

# This is the commit message #2:

outer space

# This is the commit message #3:

add files to right

# This is the commit message #4:

update

# This is the commit message #5:

relative working thing

# This is the commit message #6:

updates

# This is the commit message #7:

new font and icons

# This is the commit message #8:

close #515

# This is the commit message #9:

solve objectOf wrong type

# This is the commit message #10:

update
hacdias added a commit that referenced this issue Dec 1, 2017
# This is the 1st commit message:

# This is a combination of 2 commits.
# This is the 1st commit message:

start redesign

Too many updates to explain in a commit. See PR :O

add size and objects number

fix addresses and remove agent version

persist file history

outer space

add files to right

update

relative working thing

updates

new font and icons

close #515

solve objectOf wrong type

update

update

# This is the commit message #2:

update

# This is the commit message #2:

remove images

# This is the commit message #3:

add images

# This is the commit message #4:

Delete offline-icon.png
# This is the commit message #5:

Delete space.jpg
# This is the commit message #6:

Add files via upload
hacdias added a commit that referenced this issue Aug 29, 2019
# This is the 1st commit message:

try gh actions

License: MIT
Signed-off-by: Henrique Dias <hacdias@gmail.com>

# This is the commit message #2:

add build

License: MIT
Signed-off-by: Henrique Dias <hacdias@gmail.com>

# This is the commit message #3:

License: MIT
Signed-off-by: Henrique Dias <hacdias@gmail.com>

# This is the commit message #4:

License: MIT
Signed-off-by: Henrique Dias <hacdias@gmail.com>

# This is the commit message #5:

add gh token

License: MIT
Signed-off-by: Henrique Dias <hacdias@gmail.com>

# This is the commit message #6:

fix names

License: MIT
Signed-off-by: Henrique Dias <hacdias@gmail.com>

# This is the commit message #7:

add chrome-log driver

License: MIT
Signed-off-by: Henrique Dias <hacdias@gmail.com>

# This is the commit message #8:

License: MIT
Signed-off-by: Henrique Dias <hacdias@gmail.com>

# This is the commit message #9:

xvfb?

License: MIT
Signed-off-by: Henrique Dias <hacdias@gmail.com>

# This is the commit message #10:

install xvfb

License: MIT
Signed-off-by: Henrique Dias <hacdias@gmail.com>

# This is the commit message #11:

License: MIT
Signed-off-by: Henrique Dias <hacdias@gmail.com>

# This is the commit message #12:

License: MIT
Signed-off-by: Henrique Dias <hacdias@gmail.com>

# This is the commit message #13:

License: MIT
Signed-off-by: Henrique Dias <hacdias@gmail.com>

# This is the commit message #14:

add screensize

License: MIT
Signed-off-by: Henrique Dias <hacdias@gmail.com>

# This is the commit message #15:

License: MIT
Signed-off-by: Henrique Dias <hacdias@gmail.com>

# This is the commit message #16:

License: MIT
Signed-off-by: Henrique Dias <hacdias@gmail.com>

# This is the commit message #17:

xvfb-maybe

License: MIT
Signed-off-by: Henrique Dias <hacdias@gmail.com>

# This is the commit message #18:

chore!

License: MIT
Signed-off-by: Henrique Dias <hacdias@gmail.com>
hacdias added a commit that referenced this issue Sep 2, 2019
# This is the 1st commit message:

try gh actions

License: MIT
Signed-off-by: Henrique Dias <hacdias@gmail.com>

# This is the commit message #2:

add build

License: MIT
Signed-off-by: Henrique Dias <hacdias@gmail.com>

# This is the commit message #3:

License: MIT
Signed-off-by: Henrique Dias <hacdias@gmail.com>

# This is the commit message #4:

License: MIT
Signed-off-by: Henrique Dias <hacdias@gmail.com>

# This is the commit message #5:

add gh token

License: MIT
Signed-off-by: Henrique Dias <hacdias@gmail.com>

# This is the commit message #6:

fix names

License: MIT
Signed-off-by: Henrique Dias <hacdias@gmail.com>

# This is the commit message #7:

add chrome-log driver

License: MIT
Signed-off-by: Henrique Dias <hacdias@gmail.com>

# This is the commit message #8:

License: MIT
Signed-off-by: Henrique Dias <hacdias@gmail.com>

# This is the commit message #9:

xvfb?

License: MIT
Signed-off-by: Henrique Dias <hacdias@gmail.com>

# This is the commit message #10:

install xvfb

License: MIT
Signed-off-by: Henrique Dias <hacdias@gmail.com>

# This is the commit message #11:

License: MIT
Signed-off-by: Henrique Dias <hacdias@gmail.com>

# This is the commit message #12:

License: MIT
Signed-off-by: Henrique Dias <hacdias@gmail.com>

# This is the commit message #13:

License: MIT
Signed-off-by: Henrique Dias <hacdias@gmail.com>

# This is the commit message #14:

add screensize

License: MIT
Signed-off-by: Henrique Dias <hacdias@gmail.com>

# This is the commit message #15:

License: MIT
Signed-off-by: Henrique Dias <hacdias@gmail.com>

# This is the commit message #16:

License: MIT
Signed-off-by: Henrique Dias <hacdias@gmail.com>

# This is the commit message #17:

xvfb-maybe

License: MIT
Signed-off-by: Henrique Dias <hacdias@gmail.com>

# This is the commit message #18:

chore!

License: MIT
Signed-off-by: Henrique Dias <hacdias@gmail.com>
hacdias added a commit that referenced this issue Sep 2, 2019
# This is the 1st commit message:

try gh actions

License: MIT
Signed-off-by: Henrique Dias <hacdias@gmail.com>

# This is the commit message #2:

add build

License: MIT
Signed-off-by: Henrique Dias <hacdias@gmail.com>

# This is the commit message #3:

License: MIT
Signed-off-by: Henrique Dias <hacdias@gmail.com>

# This is the commit message #4:

License: MIT
Signed-off-by: Henrique Dias <hacdias@gmail.com>

# This is the commit message #5:

add gh token

License: MIT
Signed-off-by: Henrique Dias <hacdias@gmail.com>

# This is the commit message #6:

fix names

License: MIT
Signed-off-by: Henrique Dias <hacdias@gmail.com>

# This is the commit message #7:

add chrome-log driver

License: MIT
Signed-off-by: Henrique Dias <hacdias@gmail.com>

# This is the commit message #8:

License: MIT
Signed-off-by: Henrique Dias <hacdias@gmail.com>

# This is the commit message #9:

xvfb?

License: MIT
Signed-off-by: Henrique Dias <hacdias@gmail.com>

# This is the commit message #10:

install xvfb

License: MIT
Signed-off-by: Henrique Dias <hacdias@gmail.com>

# This is the commit message #11:

License: MIT
Signed-off-by: Henrique Dias <hacdias@gmail.com>

# This is the commit message #12:

License: MIT
Signed-off-by: Henrique Dias <hacdias@gmail.com>

# This is the commit message #13:

License: MIT
Signed-off-by: Henrique Dias <hacdias@gmail.com>

# This is the commit message #14:

add screensize

License: MIT
Signed-off-by: Henrique Dias <hacdias@gmail.com>

# This is the commit message #15:

License: MIT
Signed-off-by: Henrique Dias <hacdias@gmail.com>

# This is the commit message #16:

License: MIT
Signed-off-by: Henrique Dias <hacdias@gmail.com>

# This is the commit message #17:

xvfb-maybe

License: MIT
Signed-off-by: Henrique Dias <hacdias@gmail.com>

# This is the commit message #18:

chore!

License: MIT
Signed-off-by: Henrique Dias <hacdias@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants