Html menu #13
Merged
Html menu #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This depends upon the changes to node-ipfsd-ctl being merged. |
|
so pretty! :) |
Closed
|
@krl solid progress! congrats on getting this working. Looking very good! I've some feedback around the design, but that's a separate story than getting this stuff working in the first place -- so maybe we can merge this and finding the right design can be done in a future PR (and should probably iterate on the design in mockups a few times till we find something we really like + has great UX). |
| rm -R pkg | ||
| sudo rm -R /home/mumin/Desktop/x64 | ||
| npm run package | ||
| sudo cp -R pkg/0.1.0/linux/x64 /home/mumin/Desktop |
There was a problem hiding this comment.
probably dont want to commit this deploy.sh file
|
Comments above o/ |
|
thanks for the screenshots. very useful for people following along 👍 👍 |
|
|
|
@krl what extra review is needed here? i dont have time to read all the changes carefully atm. Im fine to merge if you think it's solid. happy to look at something closer, or read the whole thing later on. if others (@travisperson or @bcomnes) want to CR, much appreciated |
| mainWindow.webContents.on('did-finish-load', function () { | ||
| console.log('in loaded') |
There was a problem hiding this comment.
We should probably add a debugger module. debug is always my go-to, but I have no real preference.
(though this line may not even be needed for debugging)
|
@travisperson comments addressed? RFM? |
|
👍 |
|
Yes this is ready, will add an issue for some of the comments that got eaten by github |
hacdias
added a commit
that referenced
this pull request
Aug 29, 2019
# This is the 1st commit message: try gh actions License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com> # This is the commit message #2: add build License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com> # This is the commit message #3: License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com> # This is the commit message #4: License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com> # This is the commit message #5: add gh token License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com> # This is the commit message #6: fix names License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com> # This is the commit message #7: add chrome-log driver License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com> # This is the commit message #8: License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com> # This is the commit message #9: xvfb? License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com> # This is the commit message #10: install xvfb License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com> # This is the commit message #11: License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com> # This is the commit message #12: License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com> # This is the commit message #13: License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com> # This is the commit message #14: add screensize License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com> # This is the commit message #15: License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com> # This is the commit message #16: License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com> # This is the commit message #17: xvfb-maybe License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com> # This is the commit message #18: chore! License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>
hacdias
added a commit
that referenced
this pull request
Sep 2, 2019
# This is the 1st commit message: try gh actions License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com> # This is the commit message #2: add build License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com> # This is the commit message #3: License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com> # This is the commit message #4: License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com> # This is the commit message #5: add gh token License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com> # This is the commit message #6: fix names License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com> # This is the commit message #7: add chrome-log driver License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com> # This is the commit message #8: License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com> # This is the commit message #9: xvfb? License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com> # This is the commit message #10: install xvfb License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com> # This is the commit message #11: License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com> # This is the commit message #12: License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com> # This is the commit message #13: License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com> # This is the commit message #14: add screensize License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com> # This is the commit message #15: License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com> # This is the commit message #16: License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com> # This is the commit message #17: xvfb-maybe License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com> # This is the commit message #18: chore! License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>
hacdias
added a commit
that referenced
this pull request
Sep 2, 2019
# This is the 1st commit message: try gh actions License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com> # This is the commit message #2: add build License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com> # This is the commit message #3: License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com> # This is the commit message #4: License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com> # This is the commit message #5: add gh token License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com> # This is the commit message #6: fix names License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com> # This is the commit message #7: add chrome-log driver License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com> # This is the commit message #8: License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com> # This is the commit message #9: xvfb? License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com> # This is the commit message #10: install xvfb License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com> # This is the commit message #11: License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com> # This is the commit message #12: License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com> # This is the commit message #13: License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com> # This is the commit message #14: add screensize License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com> # This is the commit message #15: License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com> # This is the commit message #16: License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com> # This is the commit message #17: xvfb-maybe License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com> # This is the commit message #18: chore! License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add init helper, make menu start and stop daemon, display stats, console and browser link.