Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash on ECONNREFUSED #776

Closed
da2x opened this issue Dec 27, 2018 · 3 comments
Closed

Crash on ECONNREFUSED #776

da2x opened this issue Dec 27, 2018 · 3 comments
Labels
kind/bug A bug in existing code (including security flaws)

Comments

@da2x
Copy link

da2x commented Dec 27, 2018

  1. Open the tray and click Quit
  2. Wait, get impatient, reopen tray, and Quit again

Crash.

Specifications

  • OS: win32
  • IPFS Desktop Version: 0.6.0
  • Electron Version: 3.0.13
  • Chrome Version: 66.0.3359.181

Error

Error: connect ECONNREFUSED 127.0.0.1:5001
    at TCPConnectWrap.afterConnect [as oncomplete] (net.js:1161:14)
@hacdias
Copy link
Member

hacdias commented Dec 27, 2018

Hello @da2x! Sorry for hearing this. Did it ever started up IPFS? Was the logo glowing?

@da2x
Copy link
Author

da2x commented Dec 27, 2018

@hacdias yes, I'd been using IPFS in the browser for a few hours. Then I wanted to quit the app (high CPU over several minutes). So opened the menu, clicked the quit icon, waited a minute, opened the menu again, and clicked quit again. The crash happen immediately following this. The state of IPFS was "exiting", so I don't really know whether it was running or not at the time.

@olizilla olizilla mentioned this issue Jan 8, 2019
Closed
9 tasks
@hacdias hacdias mentioned this issue Feb 17, 2019
Merged
hacdias added a commit that referenced this issue Feb 17, 2019
@hacdias
fix: tests & quit click (#827)
589704c 
- Fixes possible edge-case where the Web UI window was already destroyed and we try to close it.
- Do not block quitting. This possibly fixes the tests and the #776 error. If the daemon happens to not exit correctly, we always do a cleanup when it starts

License: MIT
Signed-off-by: Henrique Dias <hacdias@gmail.com>
@hacdias hacdias added the kind/bug A bug in existing code (including security flaws) label Feb 17, 2019
@hacdias
Copy link
Member

hacdias commented Mar 2, 2019

I'm closing this since I think it is closed on the latest pre-release. If any of this happens again, please let me know.

@hacdias hacdias closed this as completed Mar 2, 2019
@hacdias hacdias mentioned this issue Apr 10, 2019
Closed
@hacdias hacdias changed the title Crash when attempting to quit again Crash on ECONNREFUSED Apr 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug A bug in existing code (including security flaws)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@da2x @hacdias