Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: tests & quit click #827

Merged
merged 2 commits into from
Feb 17, 2019
Merged

fix: tests & quit click #827

merged 2 commits into from
Feb 17, 2019

Conversation

hacdias
Copy link
Member

@hacdias hacdias commented Feb 17, 2019 •
edited
Loading

  • Fixes possible edge-case where the Web UI window was already destroyed and we try to close it.
  • Do not block quitting. This possibly fixes the tests and the Crash on ECONNREFUSED #776 error. If the daemon happens to not exit correctly, we always do a cleanup when it starts

License: MIT
Signed-off-by: Henrique Dias hacdias@gmail.com

@hacdias
fix: tests & quit click
57c71b4 
License: MIT
Signed-off-by: Henrique Dias <hacdias@gmail.com>
@ghost ghost assigned hacdias Feb 17, 2019
@ghost ghost added the in progress label Feb 17, 2019
@hacdias
fix: edge case test & use before quit to have more time
427fd4d 
License: MIT
Signed-off-by: Henrique Dias <hacdias@gmail.com>
@hacdias hacdias merged commit 589704c into master Feb 17, 2019
@hacdias hacdias deleted the fix/tests-click-quit branch February 17, 2019 09:36
@ghost ghost removed the in progress label Feb 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@hacdias hacdias

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hacdias