Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Refactor ctx #2114

Closed
wants to merge 3 commits into from
Closed

fix: Refactor ctx #2114

wants to merge 3 commits into from

Conversation

SgtPooki
Copy link
Member

@SgtPooki SgtPooki commented Apr 28, 2022

ctx probably still needs some additional optimizations, but this is a significant improvement

May help with #2113

fixes #1177

@SgtPooki SgtPooki requested review from lidel and hacdias April 28, 2022 15:28
@SgtPooki SgtPooki linked an issue Apr 28, 2022 that may be closed by this pull request
@SgtPooki SgtPooki mentioned this pull request Apr 28, 2022
@SgtPooki
Copy link
Member Author

SgtPooki commented Apr 29, 2022

The failing workflow (ci / test (macos-latest)) runs correctly locally, so I am restarting that job

npm run test:e2e

> ipfs-desktop@0.20.5 test:e2e
> xvfb-maybe cross-env NODE_ENV=test playwright test test/e2e/launch.e2e.test.js


Running 10 tests using 1 worker

  ✓  test/e2e/launch.e2e.test.js:66:3 › Application launch › creates a repository on startup (5s)
  ✓  test/e2e/launch.e2e.test.js:80:3 › Application launch › starts fine when node is already running (4s)
  ✓  test/e2e/launch.e2e.test.js:88:3 › Application launch › applies config migration (MDNS.enabled) (4s)
  ✓  test/e2e/launch.e2e.test.js:109:3 › Application launch › applies config migration (Web UI CORS 1) (4s)
  ✓  test/e2e/launch.e2e.test.js:131:3 › Application launch › applies config migration (Web UI CORS 2) (4s)
  ✓  test/e2e/launch.e2e.test.js:152:3 › Application launch › applies config migration (Web UI CORS 3) (4s)
  ✓  test/e2e/launch.e2e.test.js:173:3 › Application launch › applies config migration (ConnMgr) (4s)
  ✓  test/e2e/launch.e2e.test.js:194:3 › Application launch › starts with repository with "IPFS_PATH/api" file and no daemon running (6s)
  ✓  test/e2e/launch.e2e.test.js:210:3 › Application launch › starts with multiple api addresses (4s)
  ✓  test/e2e/launch.e2e.test.js:222:3 › Application launch › starts with multiple gateway addresses (4s)

  Slow test file: test/e2e/launch.e2e.test.js (42s)
  Consider splitting slow test files to speed up parallel execution

  10 passed (42s)

@SgtPooki
Copy link
Member Author

I was able to install and run the dmg from the action artifact files at the bottom of https://github.com/ipfs/ipfs-desktop/actions/runs/2240299896.

There are a few issues I'm seeing with the application, below is the content from the logs:

2022-04-29T10:07:24.871Z info: [meta] logs can be found on /Users/sgtpooki/Library/Application Support/IPFS Desktop
2022-04-29T10:07:29.330Z error: The 'screen' module can't be used before the app 'ready' event
2022-04-29T10:07:29.339Z error: dialog module can only be used after app is ready
2022-04-29T10:07:29.339Z error: dialog module can only be used after app is ready
2022-04-29T10:07:29.339Z error: dialog module can only be used after app is ready

Which wasn't occurring with npm start. I will work around these errors using the approach mentioned at electron/electron#5897 (comment)

@hacdias
Copy link
Member

hacdias commented Aug 8, 2022

@SgtPooki what's the status on this?

@SgtPooki
Copy link
Member Author

@SgtPooki what's the status on this?

I've had to de-prioritize this due to other work, but I plan on picking this back up as time becomes available outside of the kubo-rpc-client work.

@SgtPooki
Copy link
Member Author

superseded by #2378

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Refactor ctx
2 participants