WIP - Redesign #516
WIP - Redesign #516
Conversation
|
|
|
Context Menu:
|
|
Glowing icon! Perfectly beautiful. Somehow we will have to put it on WebUI! |
|
|
|
Also, @lidel pretty soon you can start recommending users to install an IPFS node through station so that they can use ipfs-companion with go-ipfs. |
|
@diasdavid apparently, PollStats was already running only when the window was opened. I don't fully understand why the #283 was opened in first instance since the code in that time already polled only if the window was visible. |
|
Ongoing welcome screen update:
The big logo at left is an heartbeat. |
|
And a note saying that IPFS is alpha software with a url to the Github issues of station |
Add further requirements to build on macOS
In #519, the CONTRIBUTING file suggests adhering to a conventions file when submitting a PR. The link to this file is broken in the Station CONTRIBUTING.md. This PR updates the link. As the originally linked page no longer exists, I am unsure if this was the intended link, but based on the now-changed project structure, the new URI is my best guess as to what was intended.
Update conventions link in CONTRIBUTING
|
@diasdavid,right now, if there is an uncaught exception, the program will just close without any warning. THere's an app.log with the info, but don't you think we should say something to the user? (most of the times is this error: #516 (comment)) |
|
@hacdias agreed. There should be an infobox with that error and then try to graciously close the program. |
| ipfs().config.get('Addresses.API') | ||
| .then((res) => { | ||
| shell.openExternal(apiAddrToUrl(res)) | ||
| }) |
There was a problem hiding this comment.
nitpick, you can reduce this to just one line: .then((res) => shell.openExternal(apiAddrToUrl(res)))
| import {apiAddrToUrl} from './utils' | ||
| import {logger} from '../config' | ||
|
|
||
| export default function openWebUI (ipfs, cb) { |
There was a problem hiding this comment.
Also, always please use callback as the top level callback of a function and cb for internal ones (makes them easier to distinguish)
|
Fantastic work @hacdias !!! This makes Station so much better 👏🏽👏🏽👏🏽👏🏽👏🏽👏🏽👏🏽👏🏽 |
Please refer to #513 for the older conversation. Based on #509.
right click~~alt clickfor settings and quit #28 (Context Menu for Settings and Exit)