This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
The resolve command should work even if the path ends in the middle of an object #1763
Labels
exp/novice
Someone with a little familiarity can pick up
P2
Medium: Good to have, but can wait until someone steps up
Comments
|
Yep agree! |
alanshaw
added
exp/novice
|
Wait. It looks like js-ipfs doesn't implement this command at all, is that right? In that case, can we just merge ipfs-inactive/interface-js-ipfs-core#385 and ipfs/kubo#5704? |
ghost
removed
the
alanshaw
pushed a commit
that referenced
this issue
Feb 19, 2019
refs ipfs-inactive/interface-js-ipfs-core#385 resolves #1763 BREAKING CHANGE: `ipfs.resolve` now supports resolving to the middle of an IPLD block instead of erroring. Given: ```js b = {"c": "some value"} a = {"b": {"/": cidOf(b) }} ``` `ipfs resolve /ipld/cidOf(a)/b/c` should return `/ipld/cidOf(b)/c`. That is, it resolves the path as much as it can. Previously it would simply fail with an error. License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Being able to path into objects, not just to objects is a crucial feature of IPLD.
Given:
ipfs resolve /ipld/cidOf(a)/b/cshould return/ipld/cidOf(b)/c. That is, it should resolve the path as much as it can.Currently, this simply fails with an error.
See: ipfs/kubo#5704
The text was updated successfully, but these errors were encountered: