This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
fix: add support for resolving to the middle of an IPLD block #1841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
Thanks @Stebalien I'll pull this over the line as soon as I get a free moment. Interested to know what your pain points were running the tests? |
|
(ok, maybe I should have just read the error message: #1869) |
Stebalien
force-pushed
the
fix/resolve-to-value
branch
from
d34747d
to
ac2e7e0
Compare
|
It looks like something is going wrong with macos. |
License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
alanshaw
force-pushed
the
fix/resolve-to-value
branch
from
ac2e7e0
to
e99b7ee
Compare
License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
|
I've removed the test in |
alanshaw
approved these changes
Feb 19, 2019
|
"EPERM: operation not permitted" error seen in the windows CI build will be resolved by #1889 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see: ipfs-inactive/interface-js-ipfs-core#385
We'll have to wait for CI, I can't get the tests to run locally, even on master.
resolves #1763