Https address adds incorrectly to preload addreses

[MicrowaveDev]

• Version: 0.35
• Platform: Browser
• Subsystem: Chrome

Type: Bug

Severity: High

Description:

I'm trying to add https preload address with specific port as described in multiaddr tests:
https://github.com/multiformats/js-mafmt/blob/master/test/index.spec.js#L79
by following code:

const ipfsPromise = new Promise((resolve, reject) => {
    const ipfs = window['Ipfs'].createNode({
          preload: {
            enabled: true,
            addresses: ['/dnsaddr/ipfs.io/tcp/3456/https/']
         }
    });
   ipfs.once('ready', () => resolve(ipfs))
   ipfs.once('error', err => reject(err))
});

But when i'm requesting for ipld:

ipfsPromise.then((ipfs) => {
    ipfs.dag.get('bafyreicxal2jgaej7ihlzhlw34ficxhjcuw43omrtlw2jcymxj7lnptjs4');
});

I see in Network tab of developer console that ipfs trying to fetch:

http://https//ipfs.io:3456/api/v0/refs?r=true&arg=zdpuArH6ZmDNgCauNuoUCgzHurvCbZ9DQdoEAvftDNsAZM5Ui

With incorrect http://https// protocol.

[MicrowaveDev]

Just found the problem:

js-ipfs/src/core/preload.js

Line 89 in f596b01

if (!(addr.endsWith('http') || addr.endsWith('https'))) {

There is no check for slash at the end of https.

Without slash at the end all working fine:
addresses: ['/dnsaddr/ipfs.io/tcp/3456/https']