Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

fix: preload addreses with trailing slash (new multiaddr-to-uri) #2377

Merged
merged 1 commit into from
Aug 21, 2019

Conversation

lidel
Copy link
Member

@lidel lidel commented Aug 21, 2019

This PR switches to latest multiaddr-to-uri and removes code that is no longer needed.

Closes #2333 as a side-effect 👌

Note: multiaddr-to-uri assumes http by default now, which should make it easier and more robust to configure: multiformats/js-multiaddr-to-uri#7

Switches to latest multiaddr-to-uri and removes code that is no longer
needed (the lib assumes http by default now:
multiformats/js-multiaddr-to-uri#7)

Closes #2333

License: MIT
Signed-off-by: Marcin Rataj <lidel@lidel.org>
@lidel lidel requested a review from alanshaw August 21, 2019 11:40
@alanshaw
Copy link
Member

Any chance you can quickly send a PR to libp2p-websockets?

⨎ npm ls multiaddr-to-uri
ipfs@0.37.0 /Users/alan/Code/pl/ipfs/js-ipfs
├─┬ libp2p-websockets@0.12.2
│ └── multiaddr-to-uri@4.0.1  deduped
└── multiaddr-to-uri@4.0.1 

@alanshaw
Copy link
Member

Tests are passing - bundlesize check is currently failing due to permissions error.

@alanshaw alanshaw merged commit c607971 into master Aug 21, 2019
@alanshaw alanshaw deleted the fix/preload-with-ending-slash-take2 branch August 21, 2019 13:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Https address adds incorrectly to preload addreses
2 participants