Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

Use interface-ipfs-core tests for the Swarm API #439

Closed
1 task done
daviddias opened this issue Aug 25, 2016 · 4 comments
Closed
1 task done

Use interface-ipfs-core tests for the Swarm API #439

daviddias opened this issue Aug 25, 2016 · 4 comments
Assignees
@dignifiedquire

Comments

@daviddias
Copy link
Member

daviddias commented Aug 25, 2016 •
edited
Loading

Uncomment https://github.com/ipfs/js-ipfs/blob/master/test/http-api/interface-ipfs-core-over-ipfs-api/test-swarm.js#L5-L23 and make it work.

Needs:
@daviddias daviddias self-assigned this Aug 25, 2016
This was referenced Aug 29, 2016
Closed
Closed
@daviddias daviddias assigned victorb and unassigned daviddias Sep 6, 2016
@daviddias daviddias mentioned this issue Sep 13, 2016
Closed
@daviddias
Copy link
Member Author

Ok, since ipfs/kubo#3218, what we needs is to fix the test swarm.connect in interface-ipfs-core to add the peer-id to the end of the multiaddr

@daviddias daviddias mentioned this issue Sep 13, 2016
Merged
1 task
@dignifiedquire
Copy link
Member

@victorbjelkholm doing this now

@victorb
Copy link
Member

victorb commented Sep 14, 2016

@dignifiedquire 👍

@daviddias
Copy link
Member Author

Thank you both :)

dignifiedquire added a commit that referenced this issue Sep 14, 2016
@dignifiedquire
feat(http): make interface-ipfs-core compliant
09d9f40 
Fixes #439
@dignifiedquire dignifiedquire mentioned this issue Sep 14, 2016
Merged
dignifiedquire added a commit that referenced this issue Sep 15, 2016
@dignifiedquire
feat(http): make interface-ipfs-core compliant
8145dfb 
Fixes #439
dignifiedquire added a commit that referenced this issue Sep 15, 2016
@dignifiedquire
feat(swarm): make interface-ipfs-core compliant
ef729bb 
Fixes #439
@awaisab172 awaisab172 mentioned this issue Jul 22, 2022
Open
@rtpro rtpro mentioned this issue Jul 23, 2022
Open
@snyk-bot snyk-bot mentioned this issue Jul 23, 2022
Open
This was referenced Aug 3, 2023
Open
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@dignifiedquire dignifiedquire

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@victorb @dignifiedquire @daviddias