This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
feat(swarm): interface-ipfs-core swarm compatibility #486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daviddias
force-pushed
the
feat/swarm-iic
branch
2 times, most recently
from
09329f3
to
3873a45
Compare
daviddias
force-pushed
the
feat/swarm-iic
branch
from
3873a45
to
3b32dfd
Compare
| // TODO this should only print the addr we are using | ||
| mas.push(ma) | ||
| }) | ||
| }) |
There was a problem hiding this comment.
Please map, instead of forEach and push
There was a problem hiding this comment.
There is two forEach, it would require a flat step then
There was a problem hiding this comment.
Then use _.flatten or pull.flatten :)
There was a problem hiding this comment.
Is requiring a dependency to remove 0 lines (because the extra map to flatten step would take the exact same lines) worth it?
There was a problem hiding this comment.
I think so, because it makes the code much easier to read and understand
|
not a big fan of merging things that are still being discussed :/ |
MicrowaveDev
pushed a commit
to galtproject/js-ipfs
that referenced
this pull request
May 22, 2020
closes ipfs-inactive/interface-js-ipfs-core#383 License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contributes to #439
Only missing: