Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

Migration of Blockstore to use multihash instead of CID as key #2522

Closed
wants to merge 2 commits into from

Conversation

AuHau
Copy link
Member

@AuHau AuHau commented Oct 8, 2019

Related to #2415

Since DHT is not enabled, I have not worked on that part.

TODO

  • Bump js-ipfs-repo version upon release
  • Bump interface-js-ipfs-core version upon release
  • Change DHT to use multihashes instead CIDs
  • Fix GC tests that I think never properly worked, but I have idea about what is wrong, seems like ipfs.block.rm() actually does not delete the blocks...

Blocked by

@AuHau AuHau force-pushed the auhau/feat/multihash_keys_in_datastore branch from 122895b to 57de7b5 Compare October 9, 2019 15:24
@daviddias
Copy link
Member

Thank you for putting energy onto this @AuHau! This is also an important piece of this Epic https://github.com/ipfs/ipfs/issues/337

@daviddias daviddias added the P1 High: Likely tackled by core team if no one steps up label Oct 10, 2019
@daviddias
Copy link
Member

@AuHau can this endeavor has so many tails that I'm having a hard time understanding what needs to happen first. Can you elaborate on what PRs need to be reviewed/merged/released first so that we can land things sequentially?

@AuHau
Copy link
Member Author

AuHau commented Oct 10, 2019

Hahah yeah, it is getting pretty tangled 😅

Well there are few parts:

  1. js-ipfs-repo-migrations tool to be finalized and released first version
  2. js-ipfs-repo-migrations tool to be integrated
  3. merge related changes

Steps 2. and 3. will have to happen pretty much in the same time...

@daviddias
Copy link
Member

Hi! js-ipfs master just got a whole new set of automated tests with #2528, #2440 and also running some of the test suites from our early testers (hi5 to @achingbrain for setting it all up!). Would you mind rebasing the master branch on this PR to ensure it runs all the latest tests? Thank you!

@AuHau AuHau force-pushed the auhau/feat/multihash_keys_in_datastore branch 2 times, most recently from 22efc26 to 0e2d24d Compare October 15, 2019 16:07
@AuHau AuHau force-pushed the auhau/feat/multihash_keys_in_datastore branch from 0e2d24d to 48cc8d0 Compare October 16, 2019 10:42
@AuHau AuHau marked this pull request as ready for review October 16, 2019 11:12
@achingbrain achingbrain mentioned this pull request Oct 23, 2019
52 tasks
@autonome autonome added the status/in-progress In progress label Jun 25, 2020
@achingbrain
Copy link
Member

Closing in favour of #3124

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P1 High: Likely tackled by core team if no one steps up status/in-progress In progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants