-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatic repo migrations #202
Conversation
9d4230f
to
8a19b3b
Compare
b7b7468
to
dab4851
Compare
8f38027
to
f0c619a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM, just some nitpicks and a nice to have.
ping @AuHau |
Sorry, got a job now, so it might take some time to get back to this. Hopefully in the following days. |
Integration of js-ipfs-repo-migrations brings automatic repo migrations to ipfs-repo (both in-browser and fs). It is possible to control the automatic migration using either config's setting 'repoDisableAutoMigration' or IPFSRepo's option 'disableAutoMigration'. License: MIT Signed-off-by: Adam Uhlir <adam@uhlir.dev>
License: MIT Signed-off-by: Adam Uhlir <adam@uhlir.dev>
40dc006
to
2d21166
Compare
2d21166
to
e737408
Compare
I believe this is ready to be merged. |
@jacobheun please can we have review+merge+release? |
@alanshaw on it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 🎉
0.29 is out! 🚀 |
Resolves: #1115 Supersedes: #2044 Depends on: * [x] ipfs/js-ipfs-repo#202
This PR brings integration of js-ipfs-repo-migrations brings automatic repo migrations to ipfs-repo (both in-browser and fs). It is possible to control the automatic migration using either config's setting 'repoDisableAutoMigration' or IPFSRepo's option 'disableAutoMigration'.
Related PRs: js-ipfs, js-ipfs-repo-migrations
Questions to tackle:
repo.version.check()
change of behaviour (throw ==> bool)