Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nomenclature for MerkelDAG objects/nodes #23

Closed
dborzov opened this issue Aug 2, 2014 · 2 comments
Closed

Nomenclature for MerkelDAG objects/nodes #23

dborzov opened this issue Aug 2, 2014 · 2 comments

Comments

@dborzov
Copy link
Contributor

dborzov commented Aug 2, 2014

This project has a lot of graph-based data structures involved and the word Node is used to refer to completely different concepts in the codebase. To avoid confusion, should we rename the MerkelDAG nodes to Objects and stick to this notation?

Let me know and I will make the refactoring PR.
@whyrusleeping
Copy link
Member

Yeah, im rather guilty of calling Peers Nodes. Ill try and make sure that I refer to individual machines in the network as peers.

@jbenet
Copy link
Member

jbenet commented Aug 2, 2014

@dborzov hm, fair point. idk, I originally called them Objects, and am fine with that, but what we get of calling it a Node is that it evokes the Web language (web of pages, dag of objects, both have nodes). Def, the running programs should be called peers. :) I'll think about it more.

(( This is why namespacing is lovely: swarm.Node vs merkledag.Node or something ;) ))

@aschmahmann aschmahmann mentioned this issue Sep 22, 2020
Closed
72 tasks
ribasushi pushed a commit that referenced this issue Jul 4, 2021
@frrist
warn when loggable key is overridden fixes #23
9fce1eb
ribasushi pushed a commit that referenced this issue Jul 4, 2021
@Stebalien
Merge pull request #24 from ipfs/fix/warnOveride
4b54e7d 
warn when loggable key is overridden fixes #23
ariescodescream pushed a commit to ariescodescream/go-ipfs that referenced this issue Oct 23, 2021
@JustinDrake
Remove outdated comment; fixes ipfs#23
88aba96
ariescodescream pushed a commit to ariescodescream/go-ipfs that referenced this issue Oct 23, 2021
@Kubuxu
Merge pull request ipfs#30 from JustinDrake/patch-1
6d0b6be 
Remove outdated comment; fixes ipfs#23
@aschmahmann aschmahmann mentioned this issue Dec 1, 2021
Closed
80 tasks
ariescodescream pushed a commit to ariescodescream/go-ipfs that referenced this issue Apr 7, 2022
@hsanjuan
Merge pull request ipfs#23 from ipfs/libp2p-6.0.29
c29d576 
gx publish 1.1.25
Jorropo pushed a commit that referenced this issue May 30, 2023
@godcong @Stebalien
fix path miss in windows/add a new api create function (#23)
be8f802 
* fix path was not always correct in windows

* add new api create function for if the port was different with api file.

* Update api.go

remove no need commit


This commit was moved from ipfs/go-ipfs-http-client@8c87deb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jbenet @dborzov @whyrusleeping