Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update warning #30

Closed
jbenet opened this issue Aug 17, 2014 · 10 comments
Closed

Update warning #30

jbenet opened this issue Aug 17, 2014 · 10 comments

Comments

@jbenet
Copy link
Member

jbenet commented Aug 17, 2014

ipfs command should check for updates from github and warn the user. This should be able to be changed in the config. Maybe:

  • update.check ignore Do not check.
  • update.check warn (default) Warn the user on every run of the ipfs command.
  • update.check error Warn the user on every run of the ipfs command, and exit.

(So, changed with ipfs config update.check ignore. )

@jbenet
Copy link
Member Author

jbenet commented Aug 17, 2014

Maybe:

Long/Obvious Error

Warning: You are running version X.X.X of go-ipfs. The latest version is Y.Y.Y. 
Since this is alpha software, it is strongly recommended you update. 

You can update go-ipfs by running

    ipfs version update

You can silence this message by running

    ipfs config update.check ignore

Short Error

Warning: You are running version X.X.X of go-ipfs. The latest version is Y.Y.Y.

@jbenet
Copy link
Member Author

jbenet commented Aug 17, 2014

@cleichner

@dborzov
Copy link
Contributor

dborzov commented Aug 17, 2014

Hey, @jbenet, should I chip in, or is it for @cleichner?

@cleichner
Copy link
Contributor

You can absolutely chip in. I was just discussing this with @jbenet IRL.

@cryptix
Copy link
Contributor

cryptix commented Aug 17, 2014

I'd consider using go-selfupdate but if it is just about warning/error for an update, using go-github's func (*RepositoriesService) ListReleases might be enough.

@dborzov
Copy link
Contributor

dborzov commented Aug 17, 2014

@cleichner , great, tnx!

@cryptix , I think adding go-github to imports is an overkill, one HTTP request to the github's API should be more than enough. Or is there something I am missing?

Maybe we can make a stable branch for releases to compare the running version's commit hash against. If we pass the current commit's hash straight to the binary during the build process somehow, it will have been pretty cool. Don't know how is that possible with plain go build though.

Passing params as code literals is dangerous though, blink and you got yourself a C-style preprocessor :))

We probably should just look up project's most recent Github releases.

@cryptix
Copy link
Contributor

cryptix commented Aug 17, 2014

@cryptix , I think adding go-github to imports is an overkill, one HTTP request to the github's API should be more than enough. Or is there something I am missing?

Point taken, I was just thinking about not repeating this and future-proofness maybe but Github wont break their API just like that most likely and it really is just a http.Get and json.Decode and since vendoring is also on the table, it really isn't worth it to include the whole github api.

@jbenet
Copy link
Member Author

jbenet commented Aug 17, 2014

Best strategy would allow deploying a new release as a semver tag (say, 0.1.2). A stable or releases branch is also fine. I'd like to save Github releases for when we reach real, wider release points (e.g. once it's actually useful). We're close, but not there yet.

@whyrusleeping
Copy link
Member

This is probably worth digging back up and thinking about again

@jbenet
Copy link
Member Author

jbenet commented Oct 14, 2014

@dborzov got the update warning done in #31 (yay)

Remaining thing to do is make automatic upgrading work. I've detailed this in #169 and #170.

@jbenet jbenet closed this as completed Mar 28, 2015
ribasushi pushed a commit that referenced this issue Jul 4, 2021
ribasushi pushed a commit that referenced this issue Jul 4, 2021
downgrade over-eager Errorf log to Debugf
ariescodescream pushed a commit to ariescodescream/go-ipfs that referenced this issue Oct 23, 2021
longfeiWan9 pushed a commit to longfeiWan9/go-ipfs that referenced this issue Nov 18, 2021
laurentsenta pushed a commit to laurentsenta/kubo that referenced this issue Feb 25, 2022
add config options for proxy/subdomain
laurentsenta pushed a commit to laurentsenta/kubo that referenced this issue Feb 25, 2022
…domains

add config options for proxy/subdomain
laurentsenta pushed a commit to laurentsenta/kubo that referenced this issue Mar 4, 2022
…domains

add config options for proxy/subdomain
laurentsenta pushed a commit to laurentsenta/kubo that referenced this issue Mar 4, 2022
…domains

add config options for proxy/subdomain
@ajnavarro ajnavarro mentioned this issue Aug 24, 2022
72 tasks
Jorropo pushed a commit that referenced this issue May 30, 2023
We're at a point where this package works pretty well and users should consider
using it.

This commit was moved from ipfs/go-ipfs-http-client@3e8506b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants