Checking for updates #31

dborzov · 2014-08-18T22:22:14Z

This PR makes ipfs reach the Github API endpoint for the list of this repo's git tags on every run. It then attempts to read the tag names as semver version labels and compares them to the running one (defined as a Version const literal in cmd/ipfs/version.go).

If the running version is older than the most recent available, the error message is shown (suggesting strongly to update) and the program exits.

This behaviour can be changed with updates.check flag in the config file. ignore and warn values are supported.

Please also note the related issue.

jbenet · 2014-09-12T00:17:21Z

@dborzov oh wow, i somehow completely missed this PR. sorry @dborzov ! would you mind rebasing it on top of new master? then we can use it

dborzov · 2014-09-12T01:16:26Z

LOL, sure, I will do it this weekend.

jbenet · 2014-09-16T07:45:06Z

thanks @dborzov :)

also, @inconshreveable made this: https://github.com/inconshreveable/go-update which could be pretty useful. I think though that for that sort of update, it should:

ask the user whether they want to update
should check for signatures on releases (not sure best way to do this with standard go-tool style installations...)

inconshreveable · 2014-09-16T10:15:09Z

@jbenet go-update has built-in support for signing and validating releases

jbenet · 2014-09-16T10:17:23Z

@inconshreveable oh great! i somehow missed that, thanks 👍

dborzov · 2014-10-06T22:32:24Z

Hey, so I am halfway through the rebase. The key changes:

Add Updates fields to the config: updates.check (can be 'error', 'warn' or 'ignore') and updates.version (version with which the ipfs node was initialized)
Add CheckForUpdates() error function (I put it into cmd/ipfs/version.go, it probably does not belong there, anyone has better ideas?) that makes a Github API request for releases in this repo and compares tag's semvers to the one set up in cmd/ipfs/version.go as a literal and returns the corresponding error.
For now I added the checker only to the local node initializer ( link). I am a little bit fuzzy on how you guys set up all that daemon business just yet, will need to read up stuff more.

dborzov · 2014-10-06T22:33:54Z

Will try to use go-update for the actual updating. Maybe in a separate pull-request?

whyrusleeping · 2014-10-07T00:17:45Z

I think the best place for any code relating to the updating (CheckForUpdates()) should live in its own package, maybe in the root as "updates" or in "config/updates"

jbenet · 2014-10-07T11:48:47Z

@dborzov all this sgtm.

For now I added the checker only to the local node initializer. I am a little bit fuzzy on how you guys set up all that daemon business just yet, will need to read up stuff more.

This is a fine place for now. Later on it can be in different common location for the cmd/ipfs tool.

I think the best place for any code relating to the updating (CheckForUpdates()) should live in its own package, maybe in the root as "updates" or in "config/updates"

Agreed. i'd go for updates.

jbenet · 2014-10-07T11:51:04Z

cmd/ipfs/init.go

@@ -129,6 +129,12 @@ func initCmd(c *commander.Command, inp []string) error {
 		},
 	}

+	// tracking ipfs version used to generate the init folder and adding update checker default setting.
+	cfg.Updates = config.Updates{
+		Check:   "error",


maybe these values ("error", "ignore", etc) should be constants in the update package:

const CheckError = "error" const CheckIgnore = "ignore" ...

dborzov · 2014-10-07T14:05:52Z

@whyrusleeping , @jbenet thanks for the feedback and CR. I updated the thing with all the changes you suggested.

dborzov · 2014-10-07T14:09:19Z

Being able to actually update go-ipfs by running ipfs version update using https://github.com/inconshreveable/go-update will be a different PR then.

jbenet · 2014-10-09T12:02:44Z

cmd/ipfs/ipfs.go

@@ -58,7 +60,8 @@ Use "ipfs help <command>" for more information about a command.
 func init() {
 	config, err := config.PathRoot()
 	if err != nil {
-		config = ""
+		u.POut("Failure initializing the default Config Directory: ", err)
+		os.Exit(1)


@dborzov this should probably not fail if the -c flag is provided to a run, which we don't know about here. I'll leave this in for now, until the -c flag works throughout commands. (doesn't atm i think)

jbenet · 2014-10-09T12:07:14Z

config/config.go

+// Version regulates checking if the most recent version is run
+type Version struct {
+	Check   string `json:"check"`   // "ignore" for do not check, "warn" and "error" for reacting when obsolete
+	Current string `json:"current"` // ipfs version for which config was generated


should we lowercase all config var names? the capitalized json is certainly odd-looking, but more admittedly more readable

cc @dborzov @whyrusleeping

Will remove the lower case tags for now for consistency.

Not to bikeshed over this too much, but the obvious future for config files format is probably toml and we will need to adopt it at some point IMHO.

i love all cases equally, i dont discriminate.

Also, you dont have to specify the lower case tag names, if your struct field is "Test" and in json its "test", go figures it out just fine.

jbenet · 2014-10-09T12:18:40Z

@dborzov sorry for extra comments after you thought we were all set! but i think these will help the UX of the updates.

* master: (107 commits) bugfixes to prev commit u.DOut -> log.Debug fixed resolver test ipfs name cmd improvements Skip ipns_test.TestMultiWrite in darwin skip ipns fuse tests in travis add another test to try and reproduce data loss issue add in some extra debug logging, and increase routing table latencies comment out debug msg use encoded (pretty) keys only on fs ds make vendor is your friend keytransform ds Rework package structure for unixfs and subpackage update error handling in ipns add more comments! vendor things New NameSystem interface deprecate merkledag.Node.Update ipns TestFastRepublish init SetupLoggers ... Conflicts resolved: cmd/ipfs/gen.go cmd/ipfs/ipfs.go config/config.go

…P request time delay

dborzov · 2014-10-09T18:05:15Z

@jbenet ok, added these changes too

jbenet · 2014-10-09T22:11:18Z

@dborzov ok, everything LGTM! thank you! I'll handle this merge later today, as tests failing, etc.

jbenet · 2014-10-10T03:03:37Z

Merged in 16b5345

jbenet · 2014-10-10T03:05:00Z

Thank you @dborzov!

feat: add a test server

dborzov changed the title ~~Checking for updates on start~~ Checking for updates Aug 18, 2014

jbenet force-pushed the master branch 2 times, most recently from ecf49fe to 2a7dafd Compare August 21, 2014 03:44

whyrusleeping force-pushed the master branch from 609a71b to 5fafaa4 Compare September 18, 2014 21:02

jbenet force-pushed the master branch from a3fd5a0 to 874d612 Compare October 2, 2014 18:26

Add Updates.Check field to Config

1e70e7e

dborzov force-pushed the update-warning branch from 2583167 to 1e70e7e Compare October 6, 2014 19:50

dborzov added 4 commits October 6, 2014 16:08

Initialize Updates.check config setting

4126585

Save ipfs version used to initialize config

6069ddb

Check for updates:if github releases with higher tag semvers exist

eb2a179

Turn on update checker for local nodes

f41d895

jbenet reviewed Oct 7, 2014
View reviewed changes

dborzov added 3 commits October 7, 2014 09:41

Rename config.Updates to config.Version

0560199

Add supported Version.Check values as consts

cd1826f

Move versioning/updates stuff to a separate package

4671230

jbenet reviewed Oct 9, 2014
View reviewed changes

jbenet mentioned this pull request Oct 9, 2014

META: Coordination #136

Closed

dborzov added 4 commits October 9, 2014 11:34

Clean up error/warning messages for consistency

9b45b52

Log it when update checking request fails

1d96fda

Limit update checks to once per configurable time period to avoid HTT…

2ad0d4f

…P request time delay

jbenet closed this Oct 10, 2014

This was referenced Oct 14, 2014

ipfs update command #169

Closed

Update warning #30

Closed

longfeiWan9 pushed a commit to longfeiWan9/go-ipfs that referenced this pull request Nov 18, 2021

Merge pull request ipfs#31 from ipfs/feat/test-server

2d4c67e

feat: add a test server

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Checking for updates #31

Checking for updates #31

dborzov commented Aug 18, 2014

jbenet commented Sep 12, 2014

dborzov commented Sep 12, 2014

jbenet commented Sep 16, 2014

inconshreveable commented Sep 16, 2014

jbenet commented Sep 16, 2014

dborzov commented Oct 6, 2014

dborzov commented Oct 6, 2014

whyrusleeping commented Oct 7, 2014

jbenet commented Oct 7, 2014

jbenet Oct 7, 2014

dborzov commented Oct 7, 2014

dborzov commented Oct 7, 2014

jbenet Oct 9, 2014

jbenet Oct 9, 2014

dborzov Oct 9, 2014

whyrusleeping Oct 9, 2014

whyrusleeping Oct 9, 2014

jbenet commented Oct 9, 2014

dborzov commented Oct 9, 2014

jbenet commented Oct 9, 2014

jbenet commented Oct 10, 2014

jbenet commented Oct 10, 2014

Checking for updates #31

Checking for updates #31

Conversation

dborzov commented Aug 18, 2014

jbenet commented Sep 12, 2014

dborzov commented Sep 12, 2014

jbenet commented Sep 16, 2014

inconshreveable commented Sep 16, 2014

jbenet commented Sep 16, 2014

dborzov commented Oct 6, 2014

dborzov commented Oct 6, 2014

whyrusleeping commented Oct 7, 2014

jbenet commented Oct 7, 2014

jbenet Oct 7, 2014

Choose a reason for hiding this comment

dborzov commented Oct 7, 2014

dborzov commented Oct 7, 2014

jbenet Oct 9, 2014

Choose a reason for hiding this comment

jbenet Oct 9, 2014

Choose a reason for hiding this comment

dborzov Oct 9, 2014

Choose a reason for hiding this comment

whyrusleeping Oct 9, 2014

Choose a reason for hiding this comment

whyrusleeping Oct 9, 2014

Choose a reason for hiding this comment

jbenet commented Oct 9, 2014

dborzov commented Oct 9, 2014

jbenet commented Oct 9, 2014

jbenet commented Oct 10, 2014

jbenet commented Oct 10, 2014