Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix get output path #4809

Merged
merged 1 commit into from
Mar 23, 2018
Merged

Fix get output path #4809

merged 1 commit into from
Mar 23, 2018

Conversation

djdv
Copy link
Contributor

@djdv djdv commented Mar 12, 2018

This return value is used to open a platform native handle, as such platform native paths should be used.
Reference: #4808

Edit: put angle brackets around email to make gitcop happy

@djdv djdv requested a review from Kubuxu as a code owner March 12, 2018 14:43
Minor but important change for platform native output paths

License: MIT
Signed-off-by: Dominic Della Valle <ddvpublic@gmail.com>
@Kubuxu Kubuxu added the RFM label Mar 12, 2018
@Kubuxu Kubuxu added this to the go-ipfs 0.4.15 milestone Mar 12, 2018
@whyrusleeping
Copy link
Member

I'm losing track of how many times this has been 'fixed' :/

@Kubuxu
Copy link
Member

Kubuxu commented Mar 14, 2018

@whyrusleeping this is something different, we were fixing -o not working with directories before. This one is about platform specific directory separators.

@djdv
Copy link
Contributor Author

djdv commented Mar 20, 2018

Closing this in favour of #4850

@djdv djdv closed this Mar 20, 2018
@djdv
Copy link
Contributor Author

djdv commented Mar 21, 2018

As it turns out, tar-utils is being moved to a new repo so I'm re-opening this one.
Edit: reference: #4857

@djdv djdv reopened this Mar 21, 2018
@ghost ghost assigned djdv Mar 21, 2018
@ghost ghost added the status/in-progress In progress label Mar 21, 2018
@whyrusleeping whyrusleeping merged commit aaf6ee7 into ipfs:master Mar 23, 2018
@ghost ghost removed the status/in-progress In progress label Mar 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants