[WIP] Sanitize get
output paths for external file systems
#4850
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows illegal paths in IPFS to be
get
-able on Windows, it also accounts for:
on Darwin, other platforms need just implement their own sanitize function and alter the build flag if they have special requirements.Darwin substitutes
:
with a hyphen-
as this is what Finder does if you try to make a file with a colon.TODO:
^
is allowed on Windows/NTFS but not Windows/FAT32, accounting for this requires detecting the output target filesystem.Currently I'm manually using a hash generated via cmd (
^
is the escape character there)it resolves to
QmP6tsejWJczc348FwKncykrRDvbVdXtb3oCCknFMQUii6\badnames\%3A^%3E%2A^bad%7Cname%5C%2A%3C%3A\Is this a file%3F
which is ugly but better than failure imo.