'peers' RPC command #78
Conversation
|
LGTM. @whyrusleeping should probably comment, given he knows that part of the codebase better. though its small enough we can merge if you want it in master tonight |
|
|
||
| for _, p := range *n.PeerMap { | ||
| addrs := make([]string, len(p.Addresses)) | ||
| for i, addr := range p.Addresses { |
There was a problem hiding this comment.
this 'i' is shadowing 'i' on L22.
On 25, you can use the presently underscored variable as an outer i
There was a problem hiding this comment.
i'd make them distinct too -- for pn, p := ... and for an, addr := ...
|
So, to start this all off, (still need to read over things more to determine safety of certain calls), could you add a user facing command "ipfs peers" that allows the user to invoke this command directly? Another cool feature would be a 'format' flag that lets the user specify how the data gets output (json vs text vs ????) |
| @@ -88,13 +89,15 @@ func NewIpfsNode(cfg *config.Config, online bool) (*IpfsNode, error) { | |||
| return nil, err | |||
| } | |||
|
|
|||
| peers = &peer.Map{} | |||
There was a problem hiding this comment.
you dont need to take a pointer to map types, theyre already psuedo reference types anyways
|
Re the |
|
@mappum excited! |
whyrusleeping
force-pushed
the
master
branch
from
609a71b
to
5fafaa4
Compare
jbenet
force-pushed
the
master
branch
2 times, most recently
from
cd43433
to
8f1c12e
Compare
|
This PR will have to change with new cmds. @mappum i'll close it for now, reopen if it changes. |
gx: remove bbloom dep
Add Init Alternative allowing specification of ED25519 key
Add Init Alternative allowing specification of ED25519 key
Add Init Alternative allowing specification of ED25519 key
Add Init Alternative allowing specification of ED25519 key
This just adds a
peersRPC command which outputs a list of the currently connected peers.Also includes a fix to
coreto populate the PeerMap, making the peer data accessible.