Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'peers' RPC command #78

Closed
wants to merge 3 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 50 additions & 0 deletions core/commands/peers.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,50 @@
package commands

import (
"encoding/json"
"io"

"github.com/jbenet/go-ipfs/core"
b58 "github.com/jbenet/go-ipfs/Godeps/_workspace/src/github.com/jbenet/go-base58"
)

// peerInfo is a representation of a peer.Peer that is better suited for serialization
type peerInfo struct {
ID string
Addresses []string
PubKey string
Latency int64
}

func Peers(n *core.IpfsNode, args []string, opts map[string]interface{}, out io.Writer) error {
enc := json.NewEncoder(out)
peers := make([]peerInfo, len(*n.PeerMap))

for i, p := range *n.PeerMap {
addrs := make([]string, len(p.Addresses))
for j, addr := range p.Addresses {
addrStr, err := addr.String()
if err != nil {
return err
}
addrs[j] = addrStr
}

pubkeyBytes, err := p.PubKey.Bytes()
if err != nil {
return err
}

peer := peerInfo{
ID: p.ID.Pretty(),
Addresses: addrs,
PubKey: b58.Encode(pubkeyBytes),
Latency: p.GetLatency().Nanoseconds(),
}
peers[i] = peer
}

enc.Encode(peers)

return nil
}
17 changes: 11 additions & 6 deletions core/core.go
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@ func NewIpfsNode(cfg *config.Config, online bool) (*IpfsNode, error) {

var (
net *swarm.Swarm
peers *peer.Map
// TODO: refactor so we can use IpfsRouting interface instead of being DHT-specific
route* dht.IpfsDHT
swap *bitswap.BitSwap
Expand All @@ -88,13 +89,15 @@ func NewIpfsNode(cfg *config.Config, online bool) (*IpfsNode, error) {
return nil, err
}

peers = &peer.Map{}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you dont need to take a pointer to map types, theyre already psuedo reference types anyways


route = dht.NewDHT(local, net, d)
route.Start()

swap = bitswap.NewBitSwap(local, net, d, route)
swap.SetStrategy(bitswap.YesManStrategy)

go initConnections(cfg, route)
go initConnections(cfg, peers, route)
}

bs, err := bserv.NewBlockService(d, swap)
Expand All @@ -106,7 +109,7 @@ func NewIpfsNode(cfg *config.Config, online bool) (*IpfsNode, error) {

return &IpfsNode{
Config: cfg,
PeerMap: &peer.Map{},
PeerMap: peers,
Datastore: d,
Blocks: bs,
DAG: dag,
Expand Down Expand Up @@ -155,18 +158,20 @@ func initIdentity(cfg *config.Config) (*peer.Peer, error) {
}, nil
}

func initConnections(cfg *config.Config, route *dht.IpfsDHT) {
for _, p := range cfg.Peers {
maddr, err := ma.NewMultiaddr(p.Address)
func initConnections(cfg *config.Config, peers *peer.Map, route *dht.IpfsDHT) {
for _, sp := range cfg.Peers {
maddr, err := ma.NewMultiaddr(sp.Address)
if err != nil {
u.PErr("error: %v\n", err)
continue
}

_, err = route.Connect(maddr)
p, err := route.Connect(maddr)
if err != nil {
u.PErr("Bootstrapping error: %v\n", err)
}

(*peers)[p.Key()] = p
}
}

Expand Down
2 changes: 2 additions & 0 deletions daemon/daemon.go
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,8 @@ func (dl *DaemonListener) handleConnection(conn net.Conn) {
err = commands.Ls(dl.node, command.Args, command.Opts, conn)
case "pin":
err = commands.Pin(dl.node, command.Args, command.Opts, conn)
case "peers":
err = commands.Peers(dl.node, command.Args, command.Opts, conn)
default:
err = fmt.Errorf("Invalid Command: '%s'", command.Command)
}
Expand Down