Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update go-libp2p to v0.26 #9656

Merged
merged 5 commits into from
Feb 24, 2023
Merged

chore: update go-libp2p to v0.26 #9656

merged 5 commits into from
Feb 24, 2023

Conversation

marten-seemann
Copy link
Member

No description provided.

lidel
lidel previously requested changes Feb 22, 2023
Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to add configuration option (Flag) Swarm.RelayService.FooLimitEnabled that is

Update: moved to separate PR (not blocking update, nor release): #9662

@marten-seemann
Copy link
Member Author

We need to add configuration option (Flag) Swarm.RelayService.FooLimitEnabled that is

This is unrelated to this PR, if I understand correctly. Kubo didn't have an option to enable a v1 relay - that's why we introduced the relay daemon.

@lidel lidel self-requested a review February 22, 2023 22:20
@lidel
Copy link
Member

lidel commented Feb 22, 2023

@marten-seemann ack, I'll add config for libp2p/go-libp2p#2125 in a separate PR, after this one is merged.

@hacdias hacdias self-requested a review February 23, 2023 08:21
@marten-seemann marten-seemann changed the title WIP: update go-libp2p to v0.26 chore: update go-libp2p to v0.26 Feb 23, 2023
@marten-seemann marten-seemann marked this pull request as ready for review February 23, 2023 08:28
@hacdias
Copy link
Member

hacdias commented Feb 23, 2023

@marten-seemann can you rebase on top of the latest master? I'll take a look in a bit. (I can also do it).

@marten-seemann
Copy link
Member Author

Updated to the official v0.26.0 release. This should be ready to go now :)

@hacdias
Copy link
Member

hacdias commented Feb 23, 2023

Things still to fix (I will take a look, but may take longer time as I'm not very knowledgeable about this codebase):

@marten-seemann
Copy link
Member Author

  • Update sharness tests with the new metrics included by go-libp2p v0.26.0

Not my business, but I've never understood why Kubo would make any assertions on the metrics exposed by libp2p. Maybe consider filtering out all libp2p_ metrics?

@hacdias
Copy link
Member

hacdias commented Feb 23, 2023

@marten-seemann yeah, definitely. I was not insinuating you should make the changes. I will take a look at that. Filtering them out seems like a better idea.

Edit: I will keep them as of now as there's some other metrics that are not entirely dependent on Kubo, but on other imported packages. For consistency, it's better to keep them all. Let's just hope I added all the remaining metrics on cb5563f. Turns out these sharness tests are not macOS friendly and it's a hassle to test them.

@hacdias

This comment was marked as outdated.

@hacdias hacdias merged commit a3366c5 into master Feb 24, 2023
@hacdias hacdias deleted the update-libp2p-v026 branch February 24, 2023 09:34
@p-shahi p-shahi mentioned this pull request Feb 25, 2023
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants