circuitv2: add a relay option to disable limits #2125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lidel
approved these changes
Feb 22, 2023
p-shahi
reviewed
Feb 22, 2023
Comment on lines
+21
to
+22
| // WithInfiniteLimits is a Relay option that disables limits. | ||
| func WithInfiniteLimits() Option { |
There was a problem hiding this comment.
Suggested change
| // WithInfiniteLimits is a Relay option that disables limits. | |
| func WithInfiniteLimits() Option { | |
| // WithInfiniteLimits is a Relay option that disables limits. | |
| // Enabling this option doesn't apply any filter for which protocols can be used. | |
| func WithInfiniteLimits() Option { |
Would it be valuable to add this additional comment?
There was a problem hiding this comment.
It's not the relay that limits the protocols, this is entirely a decision that the two endpoints using the relay make.
MarcoPolo
approved these changes
Feb 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2079.