client/rpc: migrate go-ipfs-http-client #9906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit was moved from ipfs/go-ipfs-http-client@4e7edce
This commit was moved from ipfs/go-ipfs-http-client@93943f7
This commit was moved from ipfs/go-ipfs-http-client@e823507
This commit was moved from ipfs/go-ipfs-http-client@df916c7
This commit was moved from ipfs/go-ipfs-http-client@e06cddb
This commit was moved from ipfs/go-ipfs-http-client@a23d794
This commit was moved from ipfs/go-ipfs-http-client@dfbe002
This commit was moved from ipfs/go-ipfs-http-client@d0c98b8
This commit was moved from ipfs/go-ipfs-http-client@44696b8
This commit was moved from ipfs/go-ipfs-http-client@0ffdef1
This commit was moved from ipfs/go-ipfs-http-client@c6472d9
This commit was moved from ipfs/go-ipfs-http-client@16f77b2
This commit was moved from ipfs/go-ipfs-http-client@e19e5f5
This commit was moved from ipfs/go-ipfs-http-client@eb1944f
This commit was moved from ipfs/go-ipfs-http-client@dbf90ea
This commit was moved from ipfs/go-ipfs-http-client@6169321
This commit was moved from ipfs/go-ipfs-http-client@634b00b
This commit was moved from ipfs/go-ipfs-http-client@b31bee0
This commit was moved from ipfs/go-ipfs-http-client@3217104
This commit was moved from ipfs/go-ipfs-http-client@60321ed
This commit was moved from ipfs/go-ipfs-http-client@5b2c99a
This commit was moved from ipfs/go-ipfs-http-client@2f3a77b
This commit was moved from ipfs/go-ipfs-http-client@281b2bf
This commit was moved from ipfs/go-ipfs-http-client@5bb7a58
This commit was moved from ipfs/go-ipfs-http-client@38149e4
This commit was moved from ipfs/go-ipfs-http-client@c773550
This commit was moved from ipfs/go-ipfs-http-client@0110569
This commit was moved from ipfs/go-ipfs-http-client@7abddda
This commit was moved from ipfs/go-ipfs-http-client@163b25f
This commit was moved from ipfs/go-ipfs-http-client@f34a5f6
This ensures cid-codec introduced in #8568 gets correctly passed (+ we maintain backward-compatibility with CIDv0) This commit was moved from ipfs/go-ipfs-http-client@9c9f43f
This commit was moved from ipfs/go-ipfs-http-client@026ba73
This commit was moved from ipfs/go-ipfs-http-client@c4fc1a7
sync: update CI config files This commit was moved from ipfs/go-ipfs-http-client@171fcd5
This commit was moved from ipfs/go-ipfs-http-client@c076c3c
Co-authored-by: JPexplorer <jpexplorer@pop-os.localdomain> This commit was moved from ipfs/go-ipfs-http-client@b0de2b0
This commit was moved from ipfs/go-ipfs-http-client@ae996cb
Currently any clients created through `NewApiWithClient` will make a HTTP request to the api, even if the multiaddress specifies TLS or (the deprecated multiaddr option) https. This commit addresses this by having NewApiWithClient iterate the available protocols for the multiaddress, specifying the URL proto as https if it finds TLS or HTTPS is specified. The default continues to be http for those multiaddresses that do not specify these options. Should resolve #176 This commit was moved from ipfs/go-ipfs-http-client@7e1de1f
Jorropo
force-pushed
the
go-ipfs-http-client
branch
2 times, most recently
from
2c07825
to
ccbae53
Compare
Jorropo
force-pushed
the
go-ipfs-http-client
branch
from
ccbae53
to
5189a69
Compare
11 tasks
Jorropo
force-pushed
the
go-ipfs-http-client
branch
5 times, most recently
from
46feec1
to
f1e4a15
Compare
Jorropo
force-pushed
the
go-ipfs-http-client
branch
from
f1e4a15
to
86d8e75
Compare
|
Note this needs a merge with merge not rebase nor squash. |
3 tasks
hacdias
reviewed
May 31, 2023
| @@ -4,5 +4,8 @@ linters: | |||
|
|
|||
| linters-settings: | |||
| stylecheck: | |||
| checks: | |||
| - all | |||
| - '-ST1003' | |||
There was a problem hiding this comment.
I'm fine with skipping this for now to avoid breaking people migrating, but the rule is indeed correct: https://github.com/golang/go/wiki/CodeReviewComments#initialisms
hacdias
approved these changes
May 31, 2023
hacdias
reviewed
May 31, 2023
| http-client, making it impossible to use them together with the same coreapi | ||
| version. | ||
|
|
||
| **TODO(@Jorropo)**: add link to `boxo-migrate` once support for rewriting this import path has been added |
There was a problem hiding this comment.
FYSA: I merged this PR assuming this will be updated before the release with the correct instructions. Feel free to ping me to review that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates #9124