update go-test workflow #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI failure was fixed by #12, so this should be ready to merge now. |
ipldbot
force-pushed
the
ipldbot/update-go-test
branch
from
e2e5d90
to
76af129
Compare
|
👍 but we should remove travis first I think |
|
@rvagg Who do we need to ping for that? |
|
probably me |
Merged
|
done, please rebase to fix the failures |
ipldbot
force-pushed
the
ipldbot/update-go-test
branch
from
76af129
to
13fbcee
Compare
|
@ipldbot rebase |
mvdan
approved these changes
Jan 10, 2021
|
@marten-seemann did it rebase properly? the sequence here looks like there was a force-push before your comment, but is that just the interface being inconsistent? |
|
It didn’t. There’s yet another permission issue here. We need an org-wide secret IPLDBOT_GITHUB_TOKEN so ipldbot can perform the rebase. I asked @vmx to add it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update to protocol/.github@738ae9e
You can trigger a rebase by commenting
@ipldbot rebase.