Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix decoding test on Windows #12

Merged
merged 1 commit into from
Dec 3, 2020
Merged

fix decoding test on Windows #12

merged 1 commit into from
Dec 3, 2020

Conversation

marten-seemann
Copy link
Collaborator

No description provided.

mvdan
mvdan approved these changes Dec 3, 2020
View reviewed changes
Copy link

@mvdan mvdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would also have accepted strings.TrimSpace, since hex can't contain spaces :) SGTM

@mvdan
Copy link

mvdan commented Dec 3, 2020

CI is failing because it's vastly out of date (and not reproducible). Marten's automation changes will fix that.

@mvdan mvdan merged commit eb51193 into ipld:master Dec 3, 2020
@marten-seemann marten-seemann mentioned this pull request Dec 3, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvdan mvdan mvdan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marten-seemann @mvdan